RSDK-7463 - Update Motion service in C++ SDK #238
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nfranczak
requested review from
njooma,
purplenicole730,
stuqdog and
acmorrow
and removed request for
a team
stuqdog
requested changes
May 16, 2024
There was a problem hiding this comment.
One requested change for tests, otherwise the code looks good to me.
We will need to figure out why the tests are failing before we merge this, however.
edit: also we'll want to run clang format (./bin/run-clang-format.sh) to make sure the linter test passes.
| std::vector<sdk::GeometryConfig> peek_map_obstacles; | ||
| std::shared_ptr<constraints> peek_constraints; | ||
| std::shared_ptr<sdk::motion_configuration> peek_motion_configuration; | ||
| std::vector<sdk::geo_geometry> peek_bounding_regions; |
There was a problem hiding this comment.
We've added this as a field here but we don't seem to actually set it or peek it anywhere. We should follow the example of how peek_obstacles is used (i.e., set peek_bounding_regions in the move_on_globe request and then verify that it's been set in test_motion.cpp).
github-actions
bot
force-pushed
the
workflow/update-protos
branch
2 times, most recently
from
7bea6ed
to
ed9881f
Compare
…aa0a151a0572618cc27315e639b4b
stuqdog
approved these changes
May 20, 2024
nfranczak
merged commit 19e05ab
into
viamrobotics:workflow/update-protos
3 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We are updating the python SDK to match the following changes made in API (viamrobotics/api@503a9a4)
We would like to also explicitly call out the changes reviewers should be aware of:
This means that the return type of GetObstacles in the navigation service has changes from GeoObstacle into GeoGeometry, but the navigation service is not yet a thing in this SDK so nothing to worry about here :)