[Improvement] Keep torrent app in BG when opening magnet links. #76
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
+1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The problem: when TVShows opens magnet links, it is handled by whatever application is set to handle magnet links. In my case, this app is Transmission. Despite whatever settings I use in Transmission, when that magnet link is opened, Transmission is brought to the front. This is especially undesirable when--like me--people use the same computer to run Transmission as their media center. This means as we're peacefully minding our own business, watching--let's say Plex--and TVShows opens a magnet link and Transmission pops up over our show!
I thought it was Transmission's fault, but it seems to be the way OS X handles opening URLs like magnet links. By default, it brings the app to the foreground. I found learned about this thanks to the user diamondsw on this thread: https://forums.plex.tv/index.php/topic/48190-transmission-keeps-popping-into-foreground-over-plex/
So I figured I'd be a good OSS contributor and fix this myself on TVShows (even tho this project appears to be as dead as it gets...?). As I mentioned before, tho... I'm no Obj-C dev. After much searching, I found out how to implement diamondsw's fix (see: http://zachwaugh.me/posts/opening-links-in-background-with-cocoa/), and apply it in this PR.
I believe this only applies to magnet links and not to downloading torrent files and having Transmission watch the Downloads directory.
Also, I use Tranmission as an example, but I am pretty sure any app that handles magnet links will suffer from this issue.