Merge pull request #2490 from video-dev/bugfix/source-buffer-exception

Fix `isSupported` check in browsers missing `SourceBuffer` global
video-dev · Jan 6, 2020 · 3b16e49 · 3b16e49
2 parents 908507f + e81a953
commit 3b16e49
Show file tree

Hide file tree

Showing 4 changed files with 90 additions and 66 deletions.
diff --git a/.eslintrc.js b/.eslintrc.js
@@ -76,6 +76,13 @@ module.exports = {
       'never'
     ],
 
+    'no-restricted-globals': [2,
+      {
+        'name': 'SourceBuffer',
+        'message': 'Use `self.SourceBuffer`'
+      }
+    ],
+
     'no-restricted-properties': [2,
       { 'property': 'findIndex' },  // Intended to block usage of Array.prototype.findIndex
       { 'property': 'find' }        // Intended to block usage of Array.prototype.find

diff --git a/package-lock.json b/package-lock.json
diff --git a/package.json b/package.json
@@ -80,7 +80,7 @@
     "selenium-webdriver": "^3.1.0",
     "sinon": "7.1.1",
     "sinon-chai": "3.3.0",
-    "typescript": "^3.3.1",
+    "typescript": "^3.7.4",
     "typescript-eslint-parser": "^21.0.2",
     "webpack": "^4.27.1",
     "webpack-cli": "^3.1.2",

diff --git a/src/is-supported.ts b/src/is-supported.ts
@@ -5,7 +5,7 @@ export function isSupported (): boolean {
   if (!mediaSource) {
     return false;
   }
-  const sourceBuffer = SourceBuffer || (window as any).WebKitSourceBuffer;
+  const sourceBuffer = self.SourceBuffer || (self as any).WebKitSourceBuffer as SourceBuffer;
   const isTypeSupported = mediaSource &&
     typeof mediaSource.isTypeSupported === 'function' &&
     mediaSource.isTypeSupported('video/mp4; codecs="avc1.42E01E,mp4a.40.2"');