Skip to content

Commit

Permalink
Adjust timecode hole tolerance to account for 59.94 and 29.97 framera…
Browse files Browse the repository at this point in the history
…te variance
  • Loading branch information
Rob Walch committed Jul 13, 2020
1 parent 052feab commit b1d0964
Showing 1 changed file with 3 additions and 3 deletions.
6 changes: 3 additions & 3 deletions src/remux/mp4-remuxer.js
Expand Up @@ -262,13 +262,13 @@ class MP4Remuxer {
const delta = firstDTS - nextAvcDts;
// if fragment are contiguous, detect hole/overlapping between fragments
if (contiguous) {
const foundHole = delta >= 1;
const foundHole = delta > 2;
const foundOverlap = delta < -1;
if (foundHole || foundOverlap) {
if (foundHole) {
logger.warn(`AVC: ${toMsFromMpegTsClock(delta, true)} ms hole between fragments detected, filling it`);
logger.warn(`AVC: ${toMsFromMpegTsClock(delta, true)}ms (${delta}dts) hole between fragments detected, filling it`);
} else {
logger.warn(`AVC: ${toMsFromMpegTsClock(-delta, true)} ms overlapping between fragments detected`);
logger.warn(`AVC: ${toMsFromMpegTsClock(-delta, true)}ms (${delta}dts) overlapping between fragments detected`);
}
firstDTS = nextAvcDts;
minPTS -= delta;
Expand Down

0 comments on commit b1d0964

Please sign in to comment.