Skip to content

Commit

Permalink
Remove cue duration warning, as this is standard for represending eve…
Browse files Browse the repository at this point in the history
…nt vs time-ranged based metadata in TextTracks that can be signaled during playback with activeCues change events
  • Loading branch information
Rob Walch committed Aug 4, 2020
1 parent 0476198 commit f538668
Showing 1 changed file with 0 additions and 2 deletions.
2 changes: 0 additions & 2 deletions src/controller/id3-track-controller.js
Expand Up @@ -5,7 +5,6 @@
import Event from '../events';
import EventHandler from '../event-handler';
import ID3 from '../demux/id3';
import { logger } from '../utils/logger';
import { sendAddTrackEvent, clearCurrentCues, getClosestCue } from '../utils/texttrack-utils';

const MIN_CUE_DURATION = 0.25;
Expand Down Expand Up @@ -81,7 +80,6 @@ class ID3TrackController extends EventHandler {

const timeDiff = endTime - startTime;
if (timeDiff < MIN_CUE_DURATION) {
logger.warn(`detected an id3 sample with a duration of ${timeDiff}s. Adjusting to provide a duration of ${MIN_CUE_DURATION}`);
endTime += MIN_CUE_DURATION - timeDiff;
}

Expand Down

0 comments on commit f538668

Please sign in to comment.