fix #2400 issue - add configuration for browsers with bug on addCue method #2402
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robwalch
requested changes
Oct 28, 2019
| @@ -288,16 +288,23 @@ class TimelineController extends EventHandler { | |||
| } | |||
| // Add cues and trigger event with success true. | |||
| cues.forEach(cue => { | |||
| const addTextTrackCue = (track, cue) => { | |||
There was a problem hiding this comment.
This arrow function should be defined outside the forEach. Doing it here creates a new method for each cue and the function shadows the cue argument.
| addTextTrackCue(currentTrack, cue); | ||
| } else { | ||
| try { | ||
| currentTrack.addCue(cue); |
There was a problem hiding this comment.
So LG doesn't throw when calling this method? Is there a way we could test whether it works or not, and if not throw instead?
There was a problem hiding this comment.
Right, only on LG SDK2, it doesn't throw error when cue didn't enter to the TextTracks.cues.
It could be checked on that way..
I thought about throwing but it looks weird to me to simulate error.
we can check if it's added to TextTracks.cues by id and throw error when it doesn't, to make it similar to expected behaviour.
Yuvalke
force-pushed
the
fix_issue_2400
branch
from
169c11c
to
09797f5
Compare
Yuvalke
changed the title
Yuvalke
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #2400 add configuration to go to the fallback structure for addCue method
Why is this Pull Request needed?
enable captions on problematic OS such as LG SDK 2
Resolves issues:
#2400
Checklist