fix #2400 issue - cues doesn't show up on browsers which addCue doesn't throw error with invalid structure #2431
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix video-dev#2400 throw error when the added cue isn't exist anymore
Yuvalke
changed the title
OrenMe
reviewed
Nov 4, 2019
robwalch
approved these changes
Dec 11, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #2400 for example LG SDK 2 has bug on their addCue method with different structure it won't addCue, check if the added cue is entered otherwise try the fallback structure.
Why is this Pull Request needed?
enable captions on problematic OS such as LG SDK 2
Resolves issues:
#2400
Checklist