Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: computeLivePosition minimum value of media.currentTime #2506

Merged
merged 4 commits into from Feb 26, 2020
Merged

fix: computeLivePosition minimum value of media.currentTime #2506

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
3fd87fe
fix: computeLivePosition minimum value of media.currentTime
jony89 Jan 18, 2020
077431b
Update base-stream-controller.js
jony89 Feb 26, 2020
c356efd
remove computeLive test
jony89 Feb 26, 2020
95f32a1
fix: remove uneeded tests
jony89 Feb 26, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/controller/stream-controller.js
View file
Open in desktop
Expand Up @@ -280,9 +280,9 @@ class StreamController extends BaseStreamController {

if (bufferEnd < Math.max(start - config.maxFragLookUpTolerance, end - maxLatency)) {
let liveSyncPosition = this.liveSyncPosition = this.computeLivePosition(start, levelDetails);
logger.log(`buffer end: ${bufferEnd.toFixed(3)} is located too far from the end of live sliding playlist, reset currentTime to : ${liveSyncPosition.toFixed(3)}`);
bufferEnd = liveSyncPosition;
if (media && !media.paused && media.readyState && media.duration > liveSyncPosition) {
if (media && !media.paused && media.readyState && media.duration > liveSyncPosition && liveSyncPosition > media.currentTime) {
logger.log(`buffer end: ${bufferEnd.toFixed(3)} is located too far from the end of live sliding playlist, reset currentTime to : ${liveSyncPosition.toFixed(3)}`);
media.currentTime = liveSyncPosition;
}

Expand Down