-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Parse Low-Latency HLS playlists #2865
Closed
robwalch
wants to merge
6
commits into
feature/apple-ll-hls
from
feature/ll-lhls-parse-server-control
Closed
Parse Low-Latency HLS playlists #2865
robwalch
wants to merge
6
commits into
feature/apple-ll-hls
from
feature/ll-lhls-parse-server-control
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robwalch
force-pushed
the
feature/remove-lhls-support
branch
from
July 5, 2020 16:11
f326253
to
b37b6cd
Compare
robwalch
force-pushed
the
feature/ll-lhls-parse-server-control
branch
from
July 5, 2020 16:12
f3d0f89
to
bda0dab
Compare
robwalch
force-pushed
the
feature/remove-lhls-support
branch
from
July 6, 2020 18:25
b37b6cd
to
a785a2c
Compare
robwalch
force-pushed
the
feature/ll-lhls-parse-server-control
branch
from
July 6, 2020 18:25
0fa85ac
to
426bda9
Compare
robwalch
force-pushed
the
feature/remove-lhls-support
branch
from
July 6, 2020 21:23
a785a2c
to
cc5fdfd
Compare
robwalch
force-pushed
the
feature/ll-lhls-parse-server-control
branch
2 times, most recently
from
July 6, 2020 23:54
ac1fe5e
to
370d06c
Compare
robwalch
force-pushed
the
feature/ll-lhls-parse-server-control
branch
from
July 13, 2020 19:18
370d06c
to
448f70d
Compare
zetagame
approved these changes
Jul 29, 2020
zetagame
previously approved these changes
Jul 29, 2020
robwalch
force-pushed
the
feature/ll-lhls-parse-server-control
branch
5 times, most recently
from
July 31, 2020 18:47
841913f
to
1a2d25c
Compare
robwalch
force-pushed
the
feature/ll-lhls-parse-server-control
branch
from
August 4, 2020 21:03
1a2d25c
to
bb3bfbb
Compare
robwalch
force-pushed
the
feature/ll-lhls-parse-server-control
branch
from
August 7, 2020 19:28
bb3bfbb
to
563b808
Compare
3 tasks
robwalch
force-pushed
the
feature/ll-lhls-parse-server-control
branch
from
August 11, 2020 20:19
563b808
to
b338e68
Compare
robwalch
changed the title
Parse Low-Latency HLS
Parse Low-Latency HLS playlists
Aug 12, 2020
EXT-X-SERVER-CONTROL
robwalch
force-pushed
the
feature/ll-lhls-parse-server-control
branch
from
August 15, 2020 02:16
5754829
to
761e770
Compare
robwalch
force-pushed
the
feature/ll-lhls-parse-server-control
branch
3 times, most recently
from
September 12, 2020 19:57
d04e31b
to
f1edc7a
Compare
…c is not defined by user Do not mutate config passed to Hlsjs player, and keep reference to original userConfig
robwalch
force-pushed
the
feature/ll-lhls-parse-server-control
branch
from
September 22, 2020 23:30
f1edc7a
to
75f42df
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will...
Adds support for Low-latency HLS playlist parsing https://tools.ietf.org/html/draft-pantos-hls-rfc8216bis-07#section-4.4.3.8
EXT-X-SERVER-CONTROL
attributes are added to level detailslevelDetails.canBlockReload: boolean
levelDetails.canSkipUntil: number
levelDetails.canSkipDateRanges: boolean
levelDetails.partHoldBack: number
levelDetails.holdBack: number
EXT-X-PART-INF: PART-TARGET
attribute is added to level detailslevelDetails.partTarget: number
EXT-X-PART
tags are added to fragments (parts for incomplete fragments will be added to the fragment list later when loader support is added)levelDetails.fragments[].partList: { duration: number, gap: boolean, independent: boolean, uri: string }
EXT-X-GAP
is added tofragment.tagList
EXT-X-BITRATE
is added tofragment.tagList
EXT-X-PRELOAD-HINT
attributes are added to level detailsEXT-X-RENDITION-REPORT
list is added to level detailsWhy is this Pull Request needed?
This work is a precursor to adding support for delta playlist updates, playlist block reloading, part support, and cdn tune-in.
Are there any notes?
In order to implement
HOLD-BACK
start time for live, the config passed in is no longer mutated. It is added to the merged config asuserConfig
so that we can distinguish between default options and options set by the user. This allows us to use hold-back as the target latency when the user has not set liveDurationSync/liveDurationSyncConut.Checklist
masterfeature/v1.0.0 > apple-ll-hls branch, and PR does not conflict