Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prevent immediate level switch unnecessary pause and seek #2918

Merged
merged 1 commit into from Jul 24, 2020
Merged

Prevent immediate level switch unnecessary pause and seek #2918

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
6 changes: 4 additions & 2 deletions src/controller/stream-controller.js
View file
Open in desktop
Expand Up @@ -571,7 +571,9 @@ class StreamController extends BaseStreamController {
let media = this.media, previouslyPaused;
if (media) {
previouslyPaused = media.paused;
media.pause();
if (!previouslyPaused) {
media.pause();
}
} else {
// don't restart playback after instant level switch in case media not attached
previouslyPaused = true;
Expand All @@ -597,7 +599,7 @@ class StreamController extends BaseStreamController {
const media = this.media;
if (media && media.buffered.length) {
this.immediateSwitch = false;
if (BufferHelper.isBuffered(media, media.currentTime)) {
if (media.currentTime > 0 && BufferHelper.isBuffered(media, media.currentTime)) {
// only nudge if currentTime is buffered
media.currentTime -= 0.0001;
}
Expand Down