Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bugfix for subtitle loading after hls.stopload() was used #3063

Merged
merged 16 commits into from Oct 8, 2020
Merged

Bugfix for subtitle loading after hls.stopload() was used #3063

merged 16 commits into from Oct 8, 2020

Commits on Sep 26, 2020

  1. Reset subtitle-stream-controller state to IDLE on startLoad() 

    video-dev#3053
    @netTrekfd
    netTrekfd committed Sep 26, 2020
    Copy the full SHA
    cbe8f87 View commit details
    Browse the repository at this point in the history

  2. Cleanup any existing intervals and call tick() immediately 

    video-dev#3053
    @netTrekfd
    netTrekfd committed Sep 26, 2020
    Copy the full SHA
    f2aadf7 View commit details
    Browse the repository at this point in the history

  3. Only restart interval if we have a current track 

    … otherwise it is done inside the onSubtitleTrackSwitch and/or onSubtitleTrackLoaded event.
video-dev#3053
    @netTrekfd
    netTrekfd committed Sep 26, 2020
    Copy the full SHA
    ad80f18 View commit details
    Browse the repository at this point in the history

Commits on Sep 28, 2020

  1. Fix stop loading wrong segment order after initial seek

    @netTrekfd
    netTrekfd committed Sep 28, 2020
    Copy the full SHA
    2736608 View commit details
    Browse the repository at this point in the history

Commits on Sep 29, 2020

  1. Reset subtitle-stream-controller state to IDLE on startLoad() 

    video-dev#3053
    @netTrekfd
    netTrekfd committed Sep 29, 2020
    Copy the full SHA
    cbd0b77 View commit details
    Browse the repository at this point in the history

  2. Cleanup any existing intervals and call tick() immediately 

    video-dev#3053
    @netTrekfd
    netTrekfd committed Sep 29, 2020
    Copy the full SHA
    dc3ebff View commit details
    Browse the repository at this point in the history

  3. Only restart interval if we have a current track 

    … otherwise it is done inside the onSubtitleTrackSwitch and/or onSubtitleTrackLoaded event.
video-dev#3053
    @netTrekfd
    netTrekfd committed Sep 29, 2020
    Copy the full SHA
    bc1512d View commit details
    Browse the repository at this point in the history

  4. Fix stop loading wrong segment order after initial seek

    @netTrekfd
    netTrekfd committed Sep 29, 2020
    Copy the full SHA
    30b76ea View commit details
    Browse the repository at this point in the history

  5. Merge branch 'bugfix/subtitle-loading-after-stopload' of https://gith… 

    …ub.com/netTrekfd/hls.js into bugfix/subtitle-loading-after-stopload
    @netTrekfd
    netTrekfd committed Sep 29, 2020
    Copy the full SHA
    b29432d View commit details
    Browse the repository at this point in the history

  6. Refactored fix for segment loading order after seeking

    @netTrekfd
    netTrekfd committed Sep 29, 2020
    Copy the full SHA
    991de69 View commit details
    Browse the repository at this point in the history

Commits on Sep 30, 2020

  1. Update src/controller/subtitle-stream-controller.js 

    Co-authored-by: Rob Walch <robwalch@users.noreply.github.com>
    @netTrekfd @robwalch
    netTrekfd and robwalch committed Sep 30, 2020
    Copy the full SHA
    d63cf0c View commit details
    Browse the repository at this point in the history

Commits on Oct 6, 2020

  1. Cancel existing loader on errors

    @netTrekfd
    netTrekfd committed Oct 6, 2020
    Copy the full SHA
    d107216 View commit details
    Browse the repository at this point in the history

  2. Added some checks if the seeking position is inside the currently loa… 

    …deding fragment
    @netTrekfd
    netTrekfd committed Oct 6, 2020
    Copy the full SHA
    be2e12b View commit details
    Browse the repository at this point in the history

Commits on Oct 8, 2020

  1. Update src/controller/subtitle-stream-controller.js 

    Co-authored-by: Rob Walch <robwalch@users.noreply.github.com>
    @netTrekfd @robwalch
    netTrekfd and robwalch committed Oct 8, 2020
    Copy the full SHA
    fe219db View commit details
    Browse the repository at this point in the history

  2. Removed comment

    @netTrekfd
    netTrekfd committed Oct 8, 2020
    Copy the full SHA
    d67865a View commit details
    Browse the repository at this point in the history

  3. Merge branch 'bugfix/subtitle-loading-after-stopload' of https://gith… 

    …ub.com/netTrekfd/hls.js into bugfix/subtitle-loading-after-stopload
    @netTrekfd
    netTrekfd committed Oct 8, 2020
    Copy the full SHA
    b93c938 View commit details
    Browse the repository at this point in the history