Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sample AES decryption with 48 AVC Closes: #3102 #3131

Merged

Conversation

kuczek
Copy link
Contributor

@kuczek kuczek commented Oct 19, 2020

This PR will fix Nals <= 48 going through decryption phase

Why is this Pull Request needed?

Nals <= 48 go through decryption phase
Nothing is decrypted (too few data), but discardEPB is performed, which corrupts bitstream, which results in artifacts in playback, depending on target machine + browser this may also freeze the tab/browser, as corrupt data is fed to decoder
This error looks like a typo.

Are there any points in the code the reviewer needs to double check?

No

Resolves issues:

#3102

Checklist

  • changes have been done against master branch, and PR does not conflict
  • new unit / functional tests have been added (whenever applicable)
  • API or design changes are documented in API.md

@robwalch robwalch added this to the 0.14.16 milestone Oct 19, 2020
@robwalch robwalch merged commit 28287d7 into video-dev:master Oct 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants