Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Always parse ID3 tags if type is present on the ID3 Frame #3284

Merged
merged 4 commits into from Dec 8, 2020
Merged

Always parse ID3 tags if type is present on the ID3 Frame #3284

Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
a5ff9f6
Always parse ID3 tags
Dec 8, 2020
5620e48
Remove the extra if check
Dec 8, 2020
767189d
Drop else condition entirely
Dec 8, 2020
ee16f72
Merge branch 'master' into update-id3-parsing
robwalch Dec 8, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 1 addition & 3 deletions src/demux/id3.js
View file
Open in desktop
Expand Up @@ -184,13 +184,11 @@ class ID3 {
static _decodeFrame (frame) {
if (frame.type === 'PRIV') {
return ID3._decodePrivFrame(frame);
} else if (frame.type[0] === 'T') {
return ID3._decodeTextFrame(frame);
} else if (frame.type[0] === 'W') {
return ID3._decodeURLFrame(frame);
}

return undefined;
return ID3._decodeTextFrame(frame);
}

static _readTimeStamp (timeStampFrame) {
Expand Down