Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable "age" header check with lowLatencyMode #3685

Merged
merged 5 commits into from Mar 26, 2021

Conversation

robwalch
Copy link
Collaborator

This PR will...

Disable CDN Tune-in "age" header check when lowLatencyMode is set to false

Why is this Pull Request needed?

Resolves issues:

Resolves #3680

@robwalch robwalch added this to the 1.0.0 milestone Mar 25, 2021
@robwalch robwalch added this to Top priorities in Release Planning and Backlog via automation Mar 25, 2021
@robwalch robwalch added this to In progress in Low-Latency HLS (LL-HLS) via automation Mar 25, 2021
@robwalch robwalch moved this from Top priorities to v1.0.0-rc.6 in Release Planning and Backlog Mar 25, 2021
@radiantmediaplayer
Copy link
Collaborator

I do not seem to have write access to video-dev/hls.js to update your PR so I have created a new PR to propose my fix for this issue: #3686.
One may want to read https://trackjs.com/blog/refused-unsafe-header/ for information on the fix in the new PR.

@robwalch robwalch force-pushed the bugfix/ll-hls-cdn-tune-in-low-latency-mode branch from 1009765 to b9c427c Compare March 26, 2021 19:16
@robwalch
Copy link
Collaborator Author

@radiantmediaplayer after merging your changes I applied these changes b9c427c since we no longer need to back off of checking the header since it's always safe to do so.

@robwalch robwalch merged commit 7c766a2 into master Mar 26, 2021
Low-Latency HLS (LL-HLS) automation moved this from In progress to Done Mar 26, 2021
@robwalch robwalch deleted the bugfix/ll-hls-cdn-tune-in-low-latency-mode branch March 26, 2021 20:45
@radiantmediaplayer
Copy link
Collaborator

@robwalch this is good work. Thanks again.

robwalch pushed a commit that referenced this pull request Apr 12, 2021
Fixes regression introduced in #3685 in response to #3680
robwalch pushed a commit that referenced this pull request Apr 12, 2021
Fixes regression introduced in #3685 in response to #3680
Resolves #3680
robwalch pushed a commit that referenced this pull request Apr 13, 2021
Fixes regression introduced in #3685 in response to #3680
Resolves #3680
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

Refused to get unsafe header "age" error in Chrome dev tools console
2 participants