fix: stopLoad() after destroy() becomes no-op, startLoad() after destroy() throws nicer error message. #3710
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will make error messages nicer when you call stopLoad() or startLoad() after calling destroy.
Why is this Pull Request needed?
This is a super minor fix. I was getting the very unhelpful error:
TypeError: Cannot read property 'forEach' of null
. It turns out I was callingstopLoad()
after callingdestroy()
, and was running into:but
this.networkControllers
had been set tonull
in thedestroy()
function.So this change:
networkControllers
is defined as an array or undefined.stopLoad()
whennetworkControllers
is undefined (this is a no-op now).startLoad()
on destroyed instance of hls" when you callstartLoad()
after callingdestroy()
.Are there any points in the code the reviewer needs to double check?
No
Resolves issues:
None.
Checklist