ignoreDevicePixelRatio option #3765
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lRatio in calculation for stream level choice calculations
# Conflicts: # api-extractor/report/hls.js.api.md
robwalch
requested changes
Apr 16, 2021
robwalch
previously approved these changes
Apr 19, 2021
|
@i8beef hey, it's been a while. Are you able to rebase/update this PR and resolve merge conflicts? Would make it easier to get this PR (finally) landed. |
|
Ok, I pulled and rebuilt without any issues which regenerated that md file for you. Not sure what else to do. |
|
I think that's it. Thanks! |
cjpillsbury
approved these changes
Feb 9, 2022
robwalch
approved these changes
Feb 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will...
Adds a configuration value to ignore devicePixelRatio in dimension calculations.
Why is this Pull Request needed?
Currently devicePixelRatio is always used in dimension calculation for stream choice by resolution. Dimensions set by a page developer for a video element, which may be chosen specifically for bandwidth limits, explicit quality limits, etc. will be silently adjusted without recourse, removing any control of stream choice from development time to environmental context instead.
This setting will allow those that need this explicit control to turn off devicePixelRatio adjustment for these calculations.
Are there any points in the code the reviewer needs to double check?
No
Resolves issues:
3647
Checklist