Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for multiple EXT-X-MAP tags (updated) #3859

Merged
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
27 changes: 15 additions & 12 deletions src/controller/level-helper.ts
Expand Up @@ -165,13 +165,14 @@ export function mergeDetails(
oldDetails: LevelDetails,
newDetails: LevelDetails
): void {
// potentially retrieve cached initsegment
const initMap = {};
// Track the last initSegment processed. Initialize it to the last one on the timeline.
let currentInitSegment: Fragment | null = null;
const oldFragments = oldDetails.fragments;
for (let i = 0; i < oldFragments.length; i++) {
for (let i = oldFragments.length - 1; i >= 0; i--) {
const oldInit = oldFragments[i].initSegment;
if (oldInit?.data && oldInit.relurl) {
initMap[oldInit.relurl] = oldInit;
if (oldInit) {
currentInitSegment = oldInit;
break;
}
}

Expand Down Expand Up @@ -219,6 +220,15 @@ export function mergeDetails(
newFrag.loader = oldFrag.loader;
newFrag.stats = oldFrag.stats;
newFrag.urlId = oldFrag.urlId;
if (oldFrag.initSegment) {
newFrag.initSegment = oldFrag.initSegment;
currentInitSegment = oldFrag.initSegment;
} else if (
!newFrag.initSegment ||
newFrag.initSegment.relurl == currentInitSegment?.relurl
) {
newFrag.initSegment = currentInitSegment;
}
}
);

Expand All @@ -244,13 +254,6 @@ export function mergeDetails(
}
}
if (newDetails.skippedSegments) {
for (let i = 0; i < newFragments.length; i++) {
const newFrag = newFragments[i];
const initurl = newFrag.initSegment?.relurl;
if (initurl && initMap[initurl]) {
newFrag.initSegment = initMap[initurl];
}
}
newDetails.startCC = newDetails.fragments[0].cc;
}

Expand Down
30 changes: 18 additions & 12 deletions src/loader/m3u8-parser.ts
Expand Up @@ -211,11 +211,26 @@ export default class M3U8Parser {
let i: number;
let levelkey: LevelKey | undefined;
let firstPdtIndex = -1;
let createNextFrag = false;

LEVEL_PLAYLIST_REGEX_FAST.lastIndex = 0;
level.m3u8 = string;

while ((result = LEVEL_PLAYLIST_REGEX_FAST.exec(string)) !== null) {
if (createNextFrag) {
createNextFrag = false;
frag = new Fragment(type, baseurl);
// setup the next fragment for part loading
frag.start = totalduration;
frag.sn = currentSN;
frag.cc = discontinuityCounter;
frag.level = id;
if (currentInitSegment) {
frag.initSegment = currentInitSegment;
frag.rawProgramDateTime = currentInitSegment.rawProgramDateTime;
}
}

robwalch marked this conversation as resolved.
Show resolved Hide resolved
const duration = result[1];
if (duration) {
// INF
Expand All @@ -235,9 +250,6 @@ export default class M3U8Parser {
frag.level = id;
frag.cc = discontinuityCounter;
frag.urlId = levelUrlId;
if (currentInitSegment) {
frag.initSegment = currentInitSegment;
}
fragments.push(frag);
// avoid sliced strings https://github.com/video-dev/hls.js/issues/939
frag.relurl = (' ' + result[3]).slice(1);
Expand All @@ -246,13 +258,7 @@ export default class M3U8Parser {
totalduration += frag.duration;
currentSN++;
currentPart = 0;

frag = new Fragment(type, baseurl);
// setup the next fragment for part loading
frag.start = totalduration;
frag.sn = currentSN;
frag.cc = discontinuityCounter;
frag.level = id;
createNextFrag = true;
}
} else if (result[4]) {
// X-BYTERANGE
Expand Down Expand Up @@ -428,9 +434,9 @@ export default class M3U8Parser {
if (levelkey) {
frag.levelkey = levelkey;
}
frag.initSegment = null;
currentInitSegment = frag;
frag = new Fragment(type, baseurl);
frag.rawProgramDateTime = currentInitSegment.rawProgramDateTime;
createNextFrag = true;
break;
}
case 'SERVER-CONTROL': {
Expand Down
1 change: 0 additions & 1 deletion src/loader/playlist-loader.ts
Expand Up @@ -25,7 +25,6 @@ import type {
} from '../types/loader';
import { PlaylistContextType, PlaylistLevelType } from '../types/loader';
import { LevelDetails } from './level-details';
import { Fragment } from './fragment';
import type Hls from '../hls';
import { AttrList } from '../utils/attr-list';
import type {
Expand Down