Update Release Drafter template for project workflows #4025
Conversation
robwalch
commented
Jun 8, 2021
•
robwalch
commented
- Update Release Drafter template for project workflows
- Move step into build.yml
|
Pushed a few tweaks so that it now sets the tag in the notes to the one that is being published to npm, and also uploads the release zip to the draft release. It's difficult to test so we'll just have to see if it works when it's merged 😆 |
|
I think now it will use the PR labels to set the version in the draft release, but use the one from the actual tag when the tag is pushed |
| $CHANGES | ||
|
|
||
| ## Demo Page | ||
| > Get demo url from https://github.com/video-dev/hls.js/tree/deployments |
There was a problem hiding this comment.
Is there an env var for the netlify demo URL?
There was a problem hiding this comment.
I don't think it's possible to get custom variables in yet looking at release-drafter/release-drafter#847
although that would be a neat feature, so I might have a look at that at some point
|
Thanks for the tweaks @tjenkinson! |
although it is still possible to remove the skip-changelog from rennovate PRs if there's something worthy of flagging in release notes
|
@robwalch shall we merge this? It's not possible to get the commit demo url in the message at the moment without action changes which I'm looking into separately |
| - name: create github release | ||
| id: create_release | ||
| uses: actions/create-release@v1 | ||
| with: | ||
| tag_name: ${{ github.ref }} | ||
| release_name: ${{ github.ref }} | ||
| draft: true | ||
| env: | ||
| GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} |
There was a problem hiding this comment.
@tjenkinson Is actions/create-release no longer needed?
Will release-drafter/release-drafter include all the same assets (release zip)? Ah I see your tweaks cover the zip file.
|
Looks like it worked. I just manually added the skip-change-log label to all the rennovate updates since the last release too so they should disappear on the next build |
