Schedule live reload based on start of last update request #4961
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CC @mattzucker |
Use last fragment duration rather than target duration when playhead is less than two target durations from the live edge
robwalch
force-pushed
the
bugfix/live-reload-interval-relative-to-last-request-start-and-fragment-duration
branch
from
c4263ac
to
a9d1fb3
Compare
littlespex
previously approved these changes
Oct 12, 2022
mattzucker
previously approved these changes
Oct 12, 2022
robwalch
requested review from
littlespex,
mattzucker and
cjpillsbury
and removed request for
mattzucker
littlespex
previously approved these changes
Oct 19, 2022
…t end is less than or equal to four target durations (Reload is scheduled on update. With a default live sync of 3 target durations, without interruption, a distance of 3x-4x is most likely.)
robwalch
deleted the
bugfix/live-reload-interval-relative-to-last-request-start-and-fragment-duration
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will...
setTimeoutor JavaScript executioncomputeReloadIntervaland intoplaylistLoadedwhere timer is set and last request request time (requestScheduled) is maintainedlowLatencyModeis set tofalse#3792)Why is this Pull Request needed?
Prevent saw-tooth forward buffer length pattern as playlist refreshes drift from playlist update interval or target duration.
Resolves issues:
Data provided by @wilaw showing CMCD forward buffer length on playlist requests getting shorter overtime until the difference wraps by one target duration.
Checklist