Emit and handle FRAG_PARSING_ERROR from transmuxers #5018
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robwalch
force-pushed
the
feature/drm-fairplay-key-system
branch
from
da4e9da
to
6788118
Compare
robwalch
force-pushed
the
bugfix/handle-frag-parsing-error
branch
from
f6ff457
to
c415b28
Compare
robwalch
added a commit
that referenced
this pull request
Dec 10, 2022
* Emit and handle FRAG_PARSING_ERROR from transmuxers Related to #5011 * Switch levels on Key and Fragment parsing errors or escalate to fatal error
robwalch
added a commit
that referenced
this pull request
Dec 15, 2022
* Add support for com.apple.fps keySystem * Improve support for DRM key-systems and key handling Resolves #2833 #2737 #4318 #4538 * Update README `licenseXhrSetup` example * Update api-extractor markdown * Attach CDM on start when even when initial fragments do not have a key associated with them * Handle expired key status correctly * Map key-sessions by key ID and log key ID more often than URI * Support "clear-lead" key-session creation without new config * Emit and handle FRAG_PARSING_ERROR from transmuxers (#5018) * Emit and handle FRAG_PARSING_ERROR from transmuxers Related to #5011 * Switch levels on Key and Fragment parsing errors or escalate to fatal error * Route all key-system errors to `onFragmentOrKeyLoadError` * Populate EMEKeyError.err for better demo error logging * Remove `useEmeEncryptedEvent` and mark `widevineLicenseUrl` as deprecated in API.md * Add support for EXT-X-SESSION-KEY tags (for key-system access on manifest loaded) #4927 * Throw before licenseXhrSetup if key was removed * Make key session promise chain more consice * Stop on fatal key system errors * Only request access to key-systems for keys matching those found in the config one at time (to avoid gaining access to WV and PR on Edge) * Modify key-system helpers so that it's easier to support additional key-system strings * Add undocumented `generateRequest` ("Content ID") filter Co-authored-by: Vincent Valot <vincent.valot@bedrockstreaming.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will...
transmuxer.flushresults async each time thattransmuxer.pushreturns a promise so that they push->flush results are received in orderMP4Demuxer.demuxSampleAesreturns rejected Promise throwing"The MP4 demuxer does not support SAMPLE-AES decryption"levelSwitcherror handling and escalate to fatal when switching is not possibleAre there any points in the code the reviewer needs to double check?
These changes are on top of #4930
Resolves issues:
Related to #5011 (does not yet handle fall-through probe and empty transmux response flows)
Checklist