Promisify xhrSetup #5290
Merged
Promisify xhrSetup #5290
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robwalch
reviewed
Mar 16, 2023
Comment on lines
+91
to
+99
| .then(() => { | ||
| return xhrSetup(xhr, context.url); | ||
| }) | ||
| .catch((error) => { | ||
| xhr.open('GET', context.url, true); | ||
| xhrSetup(xhr, context.url); | ||
| } | ||
| } | ||
| if (!xhr.readyState) { | ||
| xhr.open('GET', context.url, true); | ||
| } | ||
| return xhrSetup(xhr, context.url); | ||
| }) | ||
| .then(() => { | ||
| this.openAndSendXhr(xhr, context, config); |
There was a problem hiding this comment.
With async code we should check if abortInternal has been called before continuing. Do we need an this.stats.aborted check at the start of each async callback?
Something like:
.then(() => {
if (this.stats.aborted) return;
return xhrSetup(xhr, context.url); .then(() => {
if (this.stats.aborted) return;
this.openAndSendXhr(xhr, context, config);Otherwise if a loader is initialized and is immediately followed by a call to abort, with xhrSetup, the request would still be made.
|
Merged into master with
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will...
Promisify the xhrSetup. It's useful when we need to wait that xhrSetup is completed before continuing the process.
Why is this Pull Request needed?
I need to await xhrSetup. I think it could help some others.
Are there any points in the code the reviewer needs to double check?
Resolves issues:
No issue
Checklist