Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: type name error #5295

Merged
merged 2 commits into from Mar 21, 2023
Merged

fix: type name error #5295

merged 2 commits into from Mar 21, 2023

Conversation

JackPu
Copy link
Contributor

@JackPu JackPu commented Mar 15, 2023 •
edited

This PR will fix a typescript name error

MediaAttachedData is the right type for base-stram-controller.ts and his child class use it.

Why is this Pull Request needed?

There is a spell type error; And I fix it;

Are there any points in the code the reviewer needs to double check?

Don't need;

Checklist

  • changes have been done against master branch, and PR does not conflict
  • new unit / functional tests have been added (whenever applicable)
  • API or design changes are documented in API.md

@robwalch robwalch added this to the 1.4.0 milestone Mar 17, 2023
@robwalch robwalch changed the base branch from master to bugfix/type-name-issue-5295 March 21, 2023 23:57
@robwalch robwalch merged commit 91364bb into video-dev:bugfix/type-name-issue-5295 Mar 21, 2023
@robwalch
Copy link
Collaborator

Merged into master with:

  • 15fdefc Update api-extractor/report/hls.js.api.md

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@robwalch robwalch robwalch approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.4.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@JackPu @robwalch