Add strict type checking for Uint8Array/ArrayBuffer #5849
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robwalch
force-pushed
the
task/strict-arraybuffer-uint8array-type-checking
branch
from
b4811b4
to
f8b66dc
Compare
robwalch
force-pushed
the
task/strict-arraybuffer-uint8array-type-checking
branch
from
f8b66dc
to
6bbc731
Compare
robwalch
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will...
Why is this Pull Request needed?
Enforce the use of ArrayBuffers vs Uint8Array so that we pass the correct type to user-agents that may be strict about the type provided.
This should also help avoid unnecessary copying of data by creating new views from typed arrays (
copy = new Uint8Array(uint8Arr)).Are there any points in the code the reviewer needs to double check?
Resolves issues:
Checklist