[DRAFT] Skip over segments that fail to reload (by applying GAP tags) #6171
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
3 tasks
robwalch
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will...
Skip segments with fatal loading error (all retries fail, and no alternate variant to switch available)
Why is this Pull Request needed?
Are there any points in the code the reviewer needs to double check?
This changes behavior that some users might expect. You might want to know if you serve media that 404s or 500s, and error (both report errors and show the user an error) rather than skipping over it. This will remain in DRAFT form until more feedback is provided. If someone wants this feature, consider adding the missing config option to gate it.
Resolves issues:
#5153
Checklist