Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow video.js 8 #377

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

boris-petrov
Copy link

Description

Allow video.js version 8 in the dependencies.

Specific Changes proposed

Requirements Checklist

  • Feature implemented / Bug fixed
  • If necessary, more likely in a feature request than a bug fix
    • Unit Tests updated or fixed
    • Docs/guides updated
  • Reviewed by Two Core Contributors

cc @gkatsev

@gkatsev
Copy link
Member

gkatsev commented Mar 10, 2023

Thanks for the PR. Are you able to revert the package-lock update actually? I'd like it to be tied to the version of npm/node that's set in the nvmrc.

Though, all of it is needed to be updated.

@boris-petrov
Copy link
Author

@gkatsev done. Is that how you want the PR?

@gkatsev
Copy link
Member

gkatsev commented Mar 14, 2023

@boris-petrov perfect, thanks!

@gkatsev
Copy link
Member

gkatsev commented Mar 14, 2023

Just tested it locally and it works, however, https://github.com/videojs/videojs-contrib-dash/blob/main/src/js/ttml-text-track-display.js is broken with Video.js 8.
I don't have an issue with merging this PR, but won't be able to release unless that's fixed.

I think it might be "as easy" as updating videojs-generate-rollup-config to latest release. (probably not that simple since it'll be going from 2.x to 7.x).
Would likely need a major version update release of this package afterward.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants