Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(setup-audio-tracks): undefined property kind in dashTrack #381

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

amtins
Copy link

@amtins amtins commented May 14, 2023

Description

This PR fixes the use of the kind property which is undefined in the dashTrack object causing all audio tracks to have kind set to main.

Specific Changes proposed

  • adds a function to determine the kind according to the property roles and accessibility from the object dashTrack provided by dash.js.

Note

This PR does not strictly follow the specification see ref-for-audio-adaptation-set:

Clients SHALL consider there to be an implicit Role descriptor with the "Role" scheme and the value main if no explicitly defined Role descriptor with the "Role" scheme is present.

Requirements Checklist

  • Feature implemented / Bug fixed
  • If necessary, more likely in a feature request than a bug fix
    • Unit Tests updated or fixed
    • Docs/guides updated
  • Reviewed by Two Core Contributors

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant