Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf: Reduce updates #9

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

mister-ben
Copy link
Contributor

Reduces the updates and resultant DOM changes in the plugin lifecycle.

  • On 'loadstart, update the button menu rather than disposing and re-creating the button
    • Removes the now unused (internal) dispose function returned by onPlayerReady() and makes that available as player.qualityMenu.dispose() instead.
  • Debounces update() as levels are generally added in quick succession.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant