Mac libvlc loading refactoring #163
Draft
+96
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the LibraryName in the case of net core on Mac needs to be different than “libvlc" and this case cannot be determined at compile time
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Refactoring the libvlc loading for both Xamarin.Mac (cocoa) and netcore on mac targets to allow loading a libvlc dynamic build, as opposed to the current static custom built libvlc.dylib package.
This will allow to reuse the the official release builds, enabling us to do continuous delivery and will just work with libvlc 4 builds.
This PR still needs a bit of work and cleanup but it is mostly working. It relies on a new libvlc.mac nuget though, that needs to be pushed and will be incompatible with previous libvlcsharp versions.
Issues Resolved
API Changes
None
Platforms Affected
macOS on both Mono and .NET Core runtimes.
PR Checklist