Skip to content

Commit

Permalink
Update latest node version to 20
Browse files Browse the repository at this point in the history
  • Loading branch information
rtritto committed May 1, 2023
1 parent 1ca5df5 commit c685d54
Show file tree
Hide file tree
Showing 3 changed files with 10 additions and 6 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/ci.yml
Expand Up @@ -16,7 +16,7 @@ jobs:
- uses: actions/checkout@v3
- uses: actions/setup-node@v3
with:
node-version: 18
node-version: 20
- id: getMatrix
run: |
matrix=`node ./.github/workflows/ci/getTestJobs.mjs --ci`
Expand Down
6 changes: 3 additions & 3 deletions .github/workflows/ci/getTestJobs.mjs
Expand Up @@ -38,13 +38,13 @@ async function getTestJobs() {
jobName: 'Unit Tests',
jobCmd: 'pnpm run test:units',
jobTestFiles: specFiles,
jobSetups: [{ os: 'ubuntu-latest', node_version: '18' }]
jobSetups: [{ os: 'ubuntu-latest', node_version: '20' }]
},
// Typecheck `.ts` files
{
jobName: 'TypeScript',
jobCmd: 'pnpm run test:types',
jobSetups: [{ os: 'ubuntu-latest', node_version: '18' }]
jobSetups: [{ os: 'ubuntu-latest', node_version: '20' }]
},
// E2e tests
...(await crawlE2eJobs(testFiles))
Expand Down Expand Up @@ -146,7 +146,7 @@ async function crawlE2eJobs(testFiles) {
jobName: 'E2E Tests',
jobCmd: 'pnpm run test:e2e',
jobTestFiles: [],
jobSetups: [{ os: 'ubuntu-latest', node_version: '18' }]
jobSetups: [{ os: 'ubuntu-latest', node_version: '20' }]
}
jobs.push(job)
}
Expand Down
8 changes: 6 additions & 2 deletions test-e2e.config.mjs
Expand Up @@ -18,6 +18,10 @@ function getCiJobs() {
os: 'ubuntu-latest',
node_version: '18'
}
const ubuntu20 = {
os: 'ubuntu-latest',
node_version: '20'
}
const win14 = {
os: 'windows-latest',
node_version: '14'
Expand All @@ -31,12 +35,12 @@ function getCiJobs() {
node_version: '17'
}

const setupsExamples = [ubuntu16, win14]
const setupsExamples = [ubuntu18, ubuntu16, win14]

return [
{
name: 'Boilerplates',
setups: [ubuntu18]
setups: [ubuntu20]
},
{
name: 'Examples React',
Expand Down

0 comments on commit c685d54

Please sign in to comment.