Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore!: update to Node.js 20 #842

Merged
merged 15 commits into from May 8, 2023
2 changes: 1 addition & 1 deletion .github/workflows/ci.yml
Expand Up @@ -16,7 +16,7 @@ jobs:
- uses: actions/checkout@v3
- uses: actions/setup-node@v3
with:
node-version: 18
node-version: 20
- id: getMatrix
run: |
matrix=`node ./.github/workflows/ci/getTestJobs.mjs --ci`
Expand Down
6 changes: 3 additions & 3 deletions .github/workflows/ci/getTestJobs.mjs
Expand Up @@ -38,13 +38,13 @@ async function getTestJobs() {
jobName: 'Unit Tests',
jobCmd: 'pnpm run test:units',
jobTestFiles: specFiles,
jobSetups: [{ os: 'ubuntu-latest', node_version: '18' }]
jobSetups: [{ os: 'ubuntu-latest', node_version: '20' }]
},
// Typecheck `.ts` files
{
jobName: 'TypeScript',
jobCmd: 'pnpm run test:types',
jobSetups: [{ os: 'ubuntu-latest', node_version: '18' }]
jobSetups: [{ os: 'ubuntu-latest', node_version: '20' }]
},
// E2e tests
...(await crawlE2eJobs(testFiles))
Expand Down Expand Up @@ -146,7 +146,7 @@ async function crawlE2eJobs(testFiles) {
jobName: 'E2E Tests',
jobCmd: 'pnpm run test:e2e',
jobTestFiles: [],
jobSetups: [{ os: 'ubuntu-latest', node_version: '18' }]
jobSetups: [{ os: 'ubuntu-latest', node_version: '20' }]
}
jobs.push(job)
}
Expand Down
3 changes: 3 additions & 0 deletions .npmrc
Expand Up @@ -3,3 +3,6 @@ shamefully-hoist=true
# We don't control the dependencies of `examples/`. We can't fix the root causes of the warnings.
loglevel=error
strict-peer-dependencies=false
# https://pnpm.io/npmrc#resolution-mode
# https://github.com/pnpm/pnpm/issues/6463
resolution-mode=highest
4 changes: 2 additions & 2 deletions examples/telefunc/package.json
Expand Up @@ -15,8 +15,8 @@
"react": "^18.2.0",
"react-dom": "^18.2.0",
"telefunc": "^0.1.49",
"typescript": "^4.8.4",
"vite": "^3.0.9",
"typescript": "^5.0.4",
"vite": "^4.2.2",
"vite-plugin-ssr": "0.4.123"
}
}
2 changes: 1 addition & 1 deletion package.json
Expand Up @@ -62,5 +62,5 @@
}
}
},
"packageManager": "pnpm@7.9.5"
"packageManager": "pnpm@8.4.0"
}