Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some changes to workspace list and bookmark list #198

Open
wants to merge 32 commits into
base: pull-reqs
Choose a base branch
from

Conversation

yehuohan
Copy link

@yehuohan yehuohan commented Sep 6, 2017

The main changes are listed following:

  • Change bookmark list as files bookmark.
Vim-CtrlSpace
  • Change workspace list to show all workspaces of all projects that had been added.
Vim-CtrlSpace

【 And sorry for retabing some vim-files making it difficult to read the diffs. :( 】

@cometsong
Copy link
Member

@yehuohan Many of the changes in this PR are great ideas.
Overall this PR will need to be split up into smaller chunks, some of which are now in progress (in other ways) and have issues.
There are a few I've mini-hacked on my end to make it work (e.g. the projects all stored together).

@jyscao jyscao added enhancement: internal dev design, API, refactoring, testing enhancement: feature dev new requests, or significant changes to existing ones priority: 3 - wishlist and removed enhancement status: in-progress labels Nov 10, 2020
@Konfekt
Copy link
Collaborator

Konfekt commented Apr 13, 2022

@yehuohan : Thank you very much for all the great work. Would you mind documenting the commits, for example, what Change bookmark list as files bookmark, is about, and splitting the pull request up into feature branches / PRs? @jyscao Or do you prefer cherry picking?

@Konfekt
Copy link
Collaborator

Konfekt commented Dec 19, 2023

Thanks @yehuohan , is this now ready ?

@yehuohan
Copy link
Author

@Konfekt Unfortunately I have to to say that I don't plan to do that, because I don't have much time on vim-ctrlspace now (and actually I use popc now).
This PR was done at my start time with using git-pr and learning vim. So the commits aren't so beautiful and reasonable. Regret for this.
If you want to provide what this PR does for vim-ctrlspace, I think it's better to rewrite this PR with new features of neovim/vim like floating window, popup and json.
Finally, thanks vim-ctrlspace and all its contributors. :)

@Konfekt
Copy link
Collaborator

Konfekt commented Dec 20, 2023

Your popc forks looks very interesting, as it uses LeaderF or Fzf instead of the custom built binaries which seem slow on Microsoft Windows. It seems that one cannot switch between different layer views such as buffers and workspaces if I read the documentation correctly (whereas in CtrlSpace that would be achieved by hitting w as workspaces)

@yehuohan
Copy link
Author

yehuohan commented Dec 20, 2023

  • popc doesn't support any fuzzy search works (I'm not good at those algorithms). So popc just provides file paths or root path for other plugins like fzf, leaderf and telescope.
  • popc supports switching between layers you want with bindCom

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement: feature dev new requests, or significant changes to existing ones enhancement: internal dev design, API, refactoring, testing priority: 3 - wishlist
Projects
config option for `GlobalProjectRoot`...
  
Descriptions/Issues/PRs
Development

Successfully merging this pull request may close these issues.

None yet

4 participants