-
-
Notifications
You must be signed in to change notification settings - Fork 5.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
two additional remarks in documentation #14770
Conversation
runtime/doc/builtin.txt
Outdated
The {special} argument adds additional escaping of keywords | ||
used in Vim commands. When it is not omitted and a non-zero | ||
number or a non-empty String (|non-zero-arg|), then special | ||
words such as "!", "%", "#" and "<cword>" (as listed in |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can you keep the items
instead of words
please?
as pointed out by @chrisbra in vim#14770 (comment)
Fix the issues introduced by vim#14770.
Fix the issues introduced by #14770.
runtime(doc): clarify {special} argument for shellescape() closes: vim/vim#14770 vim/vim@5faeb60 N/A patch: vim-patch:c0e038b59f84 Co-authored-by: Enno <Konfekt@users.noreply.github.com>
runtime(doc): clarify {special} argument for shellescape() closes: vim/vim#14770 vim/vim@5faeb60 N/A patch: vim-patch:c0e038b59f84 Co-authored-by: Enno <Konfekt@users.noreply.github.com>
runtime(doc): clarify {special} argument for shellescape() closes: vim/vim#14770 vim/vim@5faeb60 N/A patch: vim-patch:c0e038b59f84 Co-authored-by: Enno <Konfekt@users.noreply.github.com>
@@ -10242,7 +10243,8 @@ tempname() *tempname()* *temp-file-name* | |||
is different for at least 26 consecutive calls. Example: > | |||
:let tmpfile = tempname() | |||
:exe "redir > " .. tmpfile | |||
< For Unix, the file will be in a private directory |tempfile|. | |||
< For Unix, the file will be in a private directory |tempfile| |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Somehow this comment was dropped in 5faeb60
Is this clear to everyone? I got caught off-guard once and kept wondering for a while.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It didn't get dropped, I just added the missing trailing dot back and then there was no change anymore :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When looking at https://github.com/vim/vim/pull/14770/files there's also https://github.com/vim/vim/pull/14770/files#diff-ef8946d89919ad628b9ac65c49d3067e4e017b0980cac70eb25d832a59ef677dR10247 that was meant to warn against recursive deletion of everything inside the temp dir...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hm, I might have missed to squash the third commit, sorry, let me fix it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
updated and further clarified here: 5cf5301
related: #14770 Co-authored-by: Enno <Konfekt@users.noreply.github.com> Signed-off-by: Christian Brabandt <cb@256bit.org>
runtime(doc): clarify {special} argument for shellescape() closes: vim/vim#14770 vim/vim@5faeb60 N/A patch: vim-patch:c0e038b59f84 Co-authored-by: Enno <Konfekt@users.noreply.github.com>
These two points did not seem immediately clear to everyone