Merge pull request #8494 from pvandommelen/fix_any_type_widening

Fix type widening when `Any` assertion is used
vimeo · Sep 18, 2022 · 028ac7f · 028ac7f
2 parents d957ff2 + 2eb4ca0
commit 028ac7f
Show file tree

Hide file tree

Showing 4 changed files with 25 additions and 1 deletion.
diff --git a/src/Psalm/Internal/Type/AssertionReconciler.php b/src/Psalm/Internal/Type/AssertionReconciler.php
@@ -293,6 +293,10 @@ private static function refine(
 
         $old_var_type_string = $existing_var_type->getId();
 
+        if ($new_type_part instanceof TMixed) {
+            return $existing_var_type;
+        }
+
         $new_type_has_interface = false;
 
         if ($new_type_part->isObjectType()) {

diff --git a/src/Psalm/Internal/Type/SimpleAssertionReconciler.php b/src/Psalm/Internal/Type/SimpleAssertionReconciler.php
@@ -105,7 +105,7 @@ public static function reconcile(
         int &$failed_reconciliation = Reconciler::RECONCILIATION_OK,
         bool $inside_loop = false
     ): ?Union {
-        if ($assertion instanceof Any && $existing_var_type->hasMixed()) {
+        if ($assertion instanceof Any) {
             return $existing_var_type;
         }
 

diff --git a/tests/TypeReconciliation/IssetTest.php b/tests/TypeReconciliation/IssetTest.php
@@ -188,6 +188,24 @@ function foo(array $arr) : int {
                         return $arr[$b];
                     }',
             ],
+            'issetWithCalculatedKeyAndEqualComparison' => [
+                'code' => '<?php
+                    /** @var array<string, string> $array */
+                    $array = [];
+
+                    function sameString(string $string): string {
+                        return $string;
+                    }
+
+                    if (isset($array[sameString("key")]) === false) {
+                        throw new \LogicException("No such key");
+                    }
+                    $value = $array[sameString("key")];
+                    ',
+                'assertions' => [
+                    '$value' => 'string',
+                ],
+            ],
             'issetArrayOffsetConditionalCreationWithInt' => [
                 'code' => '<?php
                     /** @param array<int, string> $arr */

diff --git a/tests/TypeReconciliation/ReconcilerTest.php b/tests/TypeReconciliation/ReconcilerTest.php
@@ -9,6 +9,7 @@
 use Psalm\Internal\Type\AssertionReconciler;
 use Psalm\Internal\Type\Comparator\UnionTypeComparator;
 use Psalm\Storage\Assertion;
+use Psalm\Storage\Assertion\Any;
 use Psalm\Storage\Assertion\Falsy;
 use Psalm\Storage\Assertion\IsIdentical;
 use Psalm\Storage\Assertion\IsLooselyEqual;
@@ -179,6 +180,7 @@ public function providerTestReconcilation(): array
             'SimpleXMLElementNotAlwaysTruthy2' => ['SimpleXMLElement', new Falsy(), 'SimpleXMLElement'],
             'SimpleXMLIteratorNotAlwaysTruthy' => ['SimpleXMLIterator', new Truthy(), 'SimpleXMLIterator'],
             'SimpleXMLIteratorNotAlwaysTruthy2' => ['SimpleXMLIterator', new Falsy(), 'SimpleXMLIterator'],
+            'stringWithAny' => ['string', new Any(), 'string'],
         ];
     }