Forbid non-null defaults for callable parameters

Fixes #3284
vimeo · Feb 16, 2023 · 1c2bc49 · 1c2bc49
1 parent f70f651
commit 1c2bc49
Show file tree

Hide file tree

Showing 3 changed files with 29 additions and 0 deletions.
diff --git a/src/Psalm/Internal/Analyzer/FunctionLikeAnalyzer.php b/src/Psalm/Internal/Analyzer/FunctionLikeAnalyzer.php
@@ -1256,6 +1256,21 @@ private function processParams(
                         ),
                     );
                 }
+
+                if ($default_type
+                    && !$default_type->isNull()
+                    && $param_type->isSingleAndMaybeNullable()
+                    && $param_type->getCallableTypes()
+                ) {
+                    IssueBuffer::maybeAdd(
+                        new InvalidParamDefault(
+                            'Default value type for ' . $param_type->getId() . ' argument ' . ($offset + 1)
+                                . ' of method ' . $cased_method_id
+                                . ' can only be null, ' . $default_type->getId() . ' specified',
+                            $function_param->type_location,
+                        ),
+                    );
+                }
             }
 
             if ($has_template_types) {

diff --git a/tests/FunctionCallTest.php b/tests/FunctionCallTest.php
@@ -2741,6 +2741,12 @@ function takesArrayShapeWithZeroOrPositiveInt(array $foo): void
                 ',
                 'error_message' => 'RedundantFunctionCall',
             ],
+            'incorrectCallableParamDefault' => [
+                'code' => '<?php
+                    function foo(callable $_a = "strlen"): void {}
+                ',
+                'error_message' => 'InvalidParamDefault',
+            ],
         ];
     }
 

diff --git a/tests/MethodCallTest.php b/tests/MethodCallTest.php
@@ -1562,6 +1562,14 @@ public function foo(): string {
                     }',
                 'error_message' => 'UndefinedMethod',
             ],
+            'incorrectCallableParamDefault' => [
+                'code' => '<?php
+                    class A {
+                        public function foo(callable $_a = "strlen"): void {}
+                    }
+                ',
+                'error_message' => 'InvalidParamDefault',
+            ],
         ];
     }
 }