Merge pull request #9356 from edsrzf/setrawcookie-impure

vimeo · Feb 21, 2023 · 28db105 · 28db105
2 parents 471a8c6 + a03299f
commit 28db105
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 1 deletion.
diff --git a/src/Psalm/Internal/Codebase/Functions.php b/src/Psalm/Internal/Codebase/Functions.php
@@ -425,7 +425,7 @@ public function isCallMapFunctionPure(
             'call_user_func', 'call_user_func_array', 'define', 'create_function',
 
             // http
-            'header', 'header_remove', 'http_response_code', 'setcookie',
+            'header', 'header_remove', 'http_response_code', 'setcookie', 'setrawcookie',
 
             // output buffer
             'ob_start', 'ob_end_clean', 'ob_get_clean', 'readfile', 'printf', 'var_dump', 'phpinfo',

diff --git a/tests/UnusedCodeTest.php b/tests/UnusedCodeTest.php
@@ -666,6 +666,13 @@ function makesACounter(int $i) : Counter {
                         return $c;
                     }',
             ],
+            'setRawCookieImpure' => [
+                'code' => '<?php
+                    setrawcookie(
+                        "name",
+                        "value",
+                    );',
+            ],
             'usedUsort' => [
                 'code' => '<?php
                     /** @param string[] $arr */