Make cache writes fail silent

vimeo · Jun 20, 2023 · 503c38d · 503c38d
1 parent 6684830
commit 503c38d
Showing 1 changed file with 3 additions and 7 deletions.
diff --git a/src/Psalm/Internal/Cache.php b/src/Psalm/Internal/Cache.php
@@ -4,7 +4,6 @@
 
 use Psalm\Config;
 use Psalm\Internal\Provider\Providers;
-use RuntimeException;
 
 use function file_exists;
 use function file_put_contents;
@@ -115,13 +114,10 @@ public function saveItem(string $path, $item): void
             $compressed = $serialized;
         }
 
-        if ($compressed === false) {
-            throw new RuntimeException(
-                'Failed to compress cache data',
-            );
+        if ($compressed !== false) {
+            file_put_contents($path, $compressed, LOCK_EX);
         }
-
-        file_put_contents($path, $compressed, LOCK_EX);
+        // TODO: Error handling
     }
 
     public function getCacheDirectory(): ?string