Reconcile IsNotType between EnumCase and NamedObject

vimeo · Feb 13, 2022 · 586c70c · 586c70c
1 parent 59d3d2a
commit 586c70c
Showing 1 changed file with 9 additions and 2 deletions.
diff --git a/src/Psalm/Internal/Type/NegatedAssertionReconciler.php b/src/Psalm/Internal/Type/NegatedAssertionReconciler.php
@@ -16,7 +16,6 @@
 use Psalm\Type\Atomic;
 use Psalm\Type\Atomic\TArray;
 use Psalm\Type\Atomic\TClassString;
-use Psalm\Type\Atomic\TEmptyMixed;
 use Psalm\Type\Atomic\TEnumCase;
 use Psalm\Type\Atomic\TFalse;
 use Psalm\Type\Atomic\TFloat;
@@ -162,6 +161,14 @@ public static function reconcile(
             return $existing_var_type;
         }
 
+        if (!$is_equality && $assertion_type instanceof TNamedObject) {
+            foreach ($existing_var_type->getAtomicTypes() as $key => $type) {
+                if ($type instanceof TEnumCase && $type->value === $assertion_type->value) {
+                    $existing_var_type->removeType($key);
+                }
+            }
+        }
+
         $codebase = $statements_analyzer->getCodebase();
 
         if ($assertion_type instanceof TNamedObject
@@ -291,7 +298,7 @@ public static function reconcile(
 
             $failed_reconciliation = Reconciler::RECONCILIATION_EMPTY;
 
-            return new Union([new TEmptyMixed]);
+            return Type::getNever();
         }
 
         return $existing_var_type;