Remove unnecessary array assignment

vimeo · Feb 16, 2022 · 6af3b50 · 6af3b50
1 parent e47752a
commit 6af3b50
Showing 1 changed file with 0 additions and 10 deletions.
diff --git a/src/Psalm/Internal/Analyzer/Statements/Expression/Fetch/ArrayFetchAnalyzer.php b/src/Psalm/Internal/Analyzer/Statements/Expression/Fetch/ArrayFetchAnalyzer.php
@@ -1163,7 +1163,6 @@ private static function handleArrayAccessOnArray(
                 $offset_type,
                 $in_assignment,
                 $expected_offset_types,
-                $replacement_type,
                 $array_access_type,
                 $original_type,
                 $has_valid_offset
@@ -1231,7 +1230,6 @@ private static function handleArrayAccessOnTArray(
         Union $offset_type,
         bool $in_assignment,
         array &$expected_offset_types,
-        ?Union $replacement_type,
         ?Union &$array_access_type,
         Atomic $original_type,
         bool &$has_valid_offset
@@ -1351,14 +1349,6 @@ private static function handleArrayAccessOnTArray(
             $type->count++;
         }
 
-        if ($in_assignment && $replacement_type) {
-            $type->type_params[1] = Type::combineUnionTypes(
-                $type->type_params[1],
-                $replacement_type,
-                $codebase
-            );
-        }
-
         $array_access_type = Type::combineUnionTypes(
             $array_access_type,
             $type->type_params[1]