report error for single param too since named args can even be used then

vimeo · Mar 13, 2024 · 6fdff44 · 6fdff44
1 parent 4ea41cb
commit 6fdff44
Show file tree

Hide file tree

Showing 2 changed files with 17 additions and 4 deletions.
diff --git a/src/Psalm/Internal/Analyzer/MethodComparator.php b/src/Psalm/Internal/Analyzer/MethodComparator.php
@@ -457,10 +457,8 @@ private static function compareMethodParams(
                     $implementer_param->location->file_path,
                 )
             ) {
-                if (!$guide_classlike_storage->user_defined && $i === 0 && count($guide_method_storage->params) < 2) {
-                    // if it's third party defined and a single arg, renaming is unnecessary
-                    // if we still want to psalter it, move this if and change the else below to elseif
-                } elseif ($config->allow_named_arg_calls
+                // even if it's just a single arg, it needs to be renamed in case it's called with a single named arg
+                if ($config->allow_named_arg_calls
                     || ($guide_classlike_storage->location
                         && !$config->isInProjectDirs($guide_classlike_storage->location->file_path)
                     )

diff --git a/tests/MethodSignatureTest.php b/tests/MethodSignatureTest.php
@@ -1060,6 +1060,21 @@ public function fooFoo(int $a, bool $c): void {
                     }',
                 'error_message' => 'ParamNameMismatch',
             ],
+            'differentArgumentName' => [
+                'code' => '<?php
+                    class A {
+                        public function fooFoo(int $a): void {
+
+                        }
+                    }
+
+                    class B extends A {
+                        public function fooFoo(int $b): void {
+
+                        }
+                    }',
+                'error_message' => 'ParamNameMismatch',
+            ],
             'nonNullableSubclassParam' => [
                 'code' => '<?php
                     class A {