Merge pull request #7595 from weirdan/finalize-issues

vimeo · Feb 6, 2022 · 7b8dc99 · 7b8dc99
2 parents 3a2b412 + aea950a
commit 7b8dc99
Show file tree

Hide file tree

Showing 285 changed files with 575 additions and 289 deletions.
diff --git a/UPGRADING.md b/UPGRADING.md
diff --git a/src/Psalm/Issue/AbstractInstantiation.php b/src/Psalm/Issue/AbstractInstantiation.php
@@ -2,7 +2,7 @@
 
 namespace Psalm\Issue;
 
-class AbstractInstantiation extends CodeIssue
+final class AbstractInstantiation extends CodeIssue
 {
     public const ERROR_LEVEL = 7;
     public const SHORTCODE = 72;

diff --git a/src/Psalm/Issue/AbstractMethodCall.php b/src/Psalm/Issue/AbstractMethodCall.php
@@ -2,7 +2,7 @@
 
 namespace Psalm\Issue;
 
-class AbstractMethodCall extends CodeIssue
+final class AbstractMethodCall extends CodeIssue
 {
     public const ERROR_LEVEL = -1;
     public const SHORTCODE = 223;

diff --git a/src/Psalm/Issue/AmbiguousConstantInheritance.php b/src/Psalm/Issue/AmbiguousConstantInheritance.php
@@ -2,7 +2,7 @@
 
 namespace Psalm\Issue;
 
-class AmbiguousConstantInheritance extends ClassConstantIssue
+final class AmbiguousConstantInheritance extends ClassConstantIssue
 {
     public const ERROR_LEVEL = 6;
     public const SHORTCODE = 305;

diff --git a/src/Psalm/Issue/ArgumentTypeCoercion.php b/src/Psalm/Issue/ArgumentTypeCoercion.php
@@ -2,7 +2,7 @@
 
 namespace Psalm\Issue;
 
-class ArgumentTypeCoercion extends ArgumentIssue
+final class ArgumentTypeCoercion extends ArgumentIssue
 {
     public const ERROR_LEVEL = 3;
     public const SHORTCODE = 193;

diff --git a/src/Psalm/Issue/AssignmentToVoid.php b/src/Psalm/Issue/AssignmentToVoid.php
@@ -2,7 +2,7 @@
 
 namespace Psalm\Issue;
 
-class AssignmentToVoid extends CodeIssue
+final class AssignmentToVoid extends CodeIssue
 {
     public const ERROR_LEVEL = 7;
     public const SHORTCODE = 121;

diff --git a/src/Psalm/Issue/CircularReference.php b/src/Psalm/Issue/CircularReference.php
@@ -2,7 +2,7 @@
 
 namespace Psalm\Issue;
 
-class CircularReference extends CodeIssue
+final class CircularReference extends CodeIssue
 {
     public const ERROR_LEVEL = 7;
     public const SHORTCODE = 131;

diff --git a/src/Psalm/Issue/ComplexFunction.php b/src/Psalm/Issue/ComplexFunction.php
@@ -2,7 +2,7 @@
 
 namespace Psalm\Issue;
 
-class ComplexFunction extends CodeIssue
+final class ComplexFunction extends CodeIssue
 {
     public const ERROR_LEVEL = -1;
     public const SHORTCODE = 259;

diff --git a/src/Psalm/Issue/ComplexMethod.php b/src/Psalm/Issue/ComplexMethod.php
@@ -2,7 +2,7 @@
 
 namespace Psalm\Issue;
 
-class ComplexMethod extends CodeIssue
+final class ComplexMethod extends CodeIssue
 {
     public const ERROR_LEVEL = -1;
     public const SHORTCODE = 260;

diff --git a/src/Psalm/Issue/ConfigIssue.php b/src/Psalm/Issue/ConfigIssue.php
@@ -2,7 +2,7 @@
 
 namespace Psalm\Issue;
 
-class ConfigIssue extends CodeIssue
+final class ConfigIssue extends CodeIssue
 {
     public const ERROR_LEVEL = -1;
     public const SHORTCODE = 271;

diff --git a/src/Psalm/Issue/ConflictingReferenceConstraint.php b/src/Psalm/Issue/ConflictingReferenceConstraint.php
@@ -2,7 +2,7 @@
 
 namespace Psalm\Issue;
 
-class ConflictingReferenceConstraint extends CodeIssue
+final class ConflictingReferenceConstraint extends CodeIssue
 {
     public const ERROR_LEVEL = 7;
     public const SHORTCODE = 85;

diff --git a/src/Psalm/Issue/ConstructorSignatureMismatch.php b/src/Psalm/Issue/ConstructorSignatureMismatch.php
@@ -2,7 +2,7 @@
 
 namespace Psalm\Issue;
 
-class ConstructorSignatureMismatch extends CodeIssue
+final class ConstructorSignatureMismatch extends CodeIssue
 {
     public const ERROR_LEVEL = 5;
     public const SHORTCODE = 231;

diff --git a/src/Psalm/Issue/ContinueOutsideLoop.php b/src/Psalm/Issue/ContinueOutsideLoop.php
@@ -2,7 +2,7 @@
 
 namespace Psalm\Issue;
 
-class ContinueOutsideLoop extends CodeIssue
+final class ContinueOutsideLoop extends CodeIssue
 {
     public const ERROR_LEVEL = 7;
     public const SHORTCODE = 43;

diff --git a/src/Psalm/Issue/DeprecatedClass.php b/src/Psalm/Issue/DeprecatedClass.php
@@ -2,7 +2,7 @@
 
 namespace Psalm\Issue;
 
-class DeprecatedClass extends ClassIssue
+final class DeprecatedClass extends ClassIssue
 {
     public const ERROR_LEVEL = 2;
     public const SHORTCODE = 98;

diff --git a/src/Psalm/Issue/DeprecatedConstant.php b/src/Psalm/Issue/DeprecatedConstant.php
@@ -2,7 +2,7 @@
 
 namespace Psalm\Issue;
 
-class DeprecatedConstant extends CodeIssue
+final class DeprecatedConstant extends CodeIssue
 {
     public const ERROR_LEVEL = 2;
     public const SHORTCODE = 170;

diff --git a/src/Psalm/Issue/DeprecatedFunction.php b/src/Psalm/Issue/DeprecatedFunction.php
@@ -2,7 +2,7 @@
 
 namespace Psalm\Issue;
 
-class DeprecatedFunction extends FunctionIssue
+final class DeprecatedFunction extends FunctionIssue
 {
     public const ERROR_LEVEL = 2;
     public const SHORTCODE = 201;

diff --git a/src/Psalm/Issue/DeprecatedInterface.php b/src/Psalm/Issue/DeprecatedInterface.php
@@ -2,7 +2,7 @@
 
 namespace Psalm\Issue;
 
-class DeprecatedInterface extends ClassIssue
+final class DeprecatedInterface extends ClassIssue
 {
     public const ERROR_LEVEL = 2;
     public const SHORTCODE = 152;

diff --git a/src/Psalm/Issue/DeprecatedMethod.php b/src/Psalm/Issue/DeprecatedMethod.php
@@ -2,7 +2,7 @@
 
 namespace Psalm\Issue;
 
-class DeprecatedMethod extends MethodIssue
+final class DeprecatedMethod extends MethodIssue
 {
     public const ERROR_LEVEL = 2;
     public const SHORTCODE = 1;

diff --git a/src/Psalm/Issue/DeprecatedProperty.php b/src/Psalm/Issue/DeprecatedProperty.php
@@ -2,7 +2,7 @@
 
 namespace Psalm\Issue;
 
-class DeprecatedProperty extends PropertyIssue
+final class DeprecatedProperty extends PropertyIssue
 {
     public const ERROR_LEVEL = 2;
     public const SHORTCODE = 99;

diff --git a/src/Psalm/Issue/DeprecatedTrait.php b/src/Psalm/Issue/DeprecatedTrait.php
@@ -2,7 +2,7 @@
 
 namespace Psalm\Issue;
 
-class DeprecatedTrait extends CodeIssue
+final class DeprecatedTrait extends CodeIssue
 {
     public const ERROR_LEVEL = 2;
     public const SHORTCODE = 171;

diff --git a/src/Psalm/Issue/DocblockTypeContradiction.php b/src/Psalm/Issue/DocblockTypeContradiction.php
@@ -4,7 +4,7 @@
 
 use Psalm\CodeLocation;
 
-class DocblockTypeContradiction extends CodeIssue
+final class DocblockTypeContradiction extends CodeIssue
 {
     public const ERROR_LEVEL = 2;
     public const SHORTCODE = 155;

diff --git a/src/Psalm/Issue/DuplicateArrayKey.php b/src/Psalm/Issue/DuplicateArrayKey.php
@@ -2,7 +2,7 @@
 
 namespace Psalm\Issue;
 
-class DuplicateArrayKey extends CodeIssue
+final class DuplicateArrayKey extends CodeIssue
 {
     public const ERROR_LEVEL = -1;
     public const SHORTCODE = 151;

diff --git a/src/Psalm/Issue/DuplicateClass.php b/src/Psalm/Issue/DuplicateClass.php
@@ -2,7 +2,7 @@
 
 namespace Psalm\Issue;
 
-class DuplicateClass extends CodeIssue
+final class DuplicateClass extends CodeIssue
 {
     public const ERROR_LEVEL = -1;
     public const SHORTCODE = 71;

diff --git a/src/Psalm/Issue/DuplicateConstant.php b/src/Psalm/Issue/DuplicateConstant.php
@@ -2,7 +2,7 @@
 
 namespace Psalm\Issue;
 
-class DuplicateConstant extends ClassIssue
+final class DuplicateConstant extends ClassIssue
 {
     public const ERROR_LEVEL = -1;
     public const SHORTCODE = 302;

diff --git a/src/Psalm/Issue/DuplicateEnumCase.php b/src/Psalm/Issue/DuplicateEnumCase.php
@@ -2,7 +2,7 @@
 
 namespace Psalm\Issue;
 
-class DuplicateEnumCase extends ClassIssue
+final class DuplicateEnumCase extends ClassIssue
 {
     public const ERROR_LEVEL = -1;
     public const SHORTCODE = 277;

diff --git a/src/Psalm/Issue/DuplicateEnumCaseValue.php b/src/Psalm/Issue/DuplicateEnumCaseValue.php
@@ -2,7 +2,7 @@
 
 namespace Psalm\Issue;
 
-class DuplicateEnumCaseValue extends ClassIssue
+final class DuplicateEnumCaseValue extends ClassIssue
 {
     public const ERROR_LEVEL = -1;
     public const SHORTCODE = 279;

diff --git a/src/Psalm/Issue/DuplicateFunction.php b/src/Psalm/Issue/DuplicateFunction.php
@@ -2,7 +2,7 @@
 
 namespace Psalm\Issue;
 
-class DuplicateFunction extends CodeIssue
+final class DuplicateFunction extends CodeIssue
 {
     public const ERROR_LEVEL = -1;
     public const SHORTCODE = 180;

diff --git a/src/Psalm/Issue/DuplicateMethod.php b/src/Psalm/Issue/DuplicateMethod.php
@@ -2,7 +2,7 @@
 
 namespace Psalm\Issue;
 
-class DuplicateMethod extends CodeIssue
+final class DuplicateMethod extends CodeIssue
 {
     public const ERROR_LEVEL = -1;
     public const SHORTCODE = 178;

diff --git a/src/Psalm/Issue/DuplicateParam.php b/src/Psalm/Issue/DuplicateParam.php
@@ -2,7 +2,7 @@
 
 namespace Psalm\Issue;
 
-class DuplicateParam extends CodeIssue
+final class DuplicateParam extends CodeIssue
 {
     public const ERROR_LEVEL = -1;
     public const SHORTCODE = 65;

diff --git a/src/Psalm/Issue/EmptyArrayAccess.php b/src/Psalm/Issue/EmptyArrayAccess.php
@@ -2,7 +2,7 @@
 
 namespace Psalm\Issue;
 
-class EmptyArrayAccess extends CodeIssue
+final class EmptyArrayAccess extends CodeIssue
 {
     public const ERROR_LEVEL = -1;
     public const SHORTCODE = 100;

diff --git a/src/Psalm/Issue/ExtensionRequirementViolation.php b/src/Psalm/Issue/ExtensionRequirementViolation.php
@@ -2,7 +2,7 @@
 
 namespace Psalm\Issue;
 
-class ExtensionRequirementViolation extends CodeIssue
+final class ExtensionRequirementViolation extends CodeIssue
 {
     public const ERROR_LEVEL = -1;
     public const SHORTCODE = 239;

diff --git a/src/Psalm/Issue/FalsableReturnStatement.php b/src/Psalm/Issue/FalsableReturnStatement.php
@@ -2,7 +2,7 @@
 
 namespace Psalm\Issue;
 
-class FalsableReturnStatement extends CodeIssue
+final class FalsableReturnStatement extends CodeIssue
 {
     public const ERROR_LEVEL = 5;
     public const SHORTCODE = 137;

diff --git a/src/Psalm/Issue/FalseOperand.php b/src/Psalm/Issue/FalseOperand.php
@@ -2,7 +2,7 @@
 
 namespace Psalm\Issue;
 
-class FalseOperand extends CodeIssue
+final class FalseOperand extends CodeIssue
 {
     public const ERROR_LEVEL = 4;
     public const SHORTCODE = 161;

diff --git a/src/Psalm/Issue/ForbiddenCode.php b/src/Psalm/Issue/ForbiddenCode.php
@@ -2,7 +2,7 @@
 
 namespace Psalm\Issue;
 
-class ForbiddenCode extends CodeIssue
+final class ForbiddenCode extends CodeIssue
 {
     public const ERROR_LEVEL = 4;
     public const SHORTCODE = 2;

diff --git a/src/Psalm/Issue/IfThisIsMismatch.php b/src/Psalm/Issue/IfThisIsMismatch.php
@@ -2,7 +2,7 @@
 
 namespace Psalm\Issue;
 
-class IfThisIsMismatch extends CodeIssue
+final class IfThisIsMismatch extends CodeIssue
 {
     public const ERROR_LEVEL = 4;
     public const SHORTCODE = 300;

diff --git a/src/Psalm/Issue/ImplementationRequirementViolation.php b/src/Psalm/Issue/ImplementationRequirementViolation.php
@@ -2,7 +2,7 @@
 
 namespace Psalm\Issue;
 
-class ImplementationRequirementViolation extends CodeIssue
+final class ImplementationRequirementViolation extends CodeIssue
 {
     public const ERROR_LEVEL = -1;
     public const SHORTCODE = 240;

diff --git a/src/Psalm/Issue/ImplementedParamTypeMismatch.php b/src/Psalm/Issue/ImplementedParamTypeMismatch.php
@@ -2,7 +2,7 @@
 
 namespace Psalm\Issue;
 
-class ImplementedParamTypeMismatch extends CodeIssue
+final class ImplementedParamTypeMismatch extends CodeIssue
 {
     public const ERROR_LEVEL = 4;
     public const SHORTCODE = 199;

diff --git a/src/Psalm/Issue/ImplementedReturnTypeMismatch.php b/src/Psalm/Issue/ImplementedReturnTypeMismatch.php
@@ -2,7 +2,7 @@
 
 namespace Psalm\Issue;
 
-class ImplementedReturnTypeMismatch extends CodeIssue
+final class ImplementedReturnTypeMismatch extends CodeIssue
 {
     public const ERROR_LEVEL = 4;
     public const SHORTCODE = 123;

diff --git a/src/Psalm/Issue/ImplicitToStringCast.php b/src/Psalm/Issue/ImplicitToStringCast.php
@@ -2,7 +2,7 @@
 
 namespace Psalm\Issue;
 
-class ImplicitToStringCast extends CodeIssue
+final class ImplicitToStringCast extends CodeIssue
 {
     public const ERROR_LEVEL = 4;
     public const SHORTCODE = 60;

diff --git a/src/Psalm/Issue/ImpureByReferenceAssignment.php b/src/Psalm/Issue/ImpureByReferenceAssignment.php
@@ -2,7 +2,7 @@
 
 namespace Psalm\Issue;
 
-class ImpureByReferenceAssignment extends CodeIssue
+final class ImpureByReferenceAssignment extends CodeIssue
 {
     public const ERROR_LEVEL = -1;
     public const SHORTCODE = 220;

diff --git a/src/Psalm/Issue/ImpureFunctionCall.php b/src/Psalm/Issue/ImpureFunctionCall.php
@@ -2,7 +2,7 @@
 
 namespace Psalm\Issue;
 
-class ImpureFunctionCall extends CodeIssue
+final class ImpureFunctionCall extends CodeIssue
 {
     public const ERROR_LEVEL = -1;
     public const SHORTCODE = 202;

diff --git a/src/Psalm/Issue/ImpureMethodCall.php b/src/Psalm/Issue/ImpureMethodCall.php
@@ -2,7 +2,7 @@
 
 namespace Psalm\Issue;
 
-class ImpureMethodCall extends CodeIssue
+final class ImpureMethodCall extends CodeIssue
 {
     public const ERROR_LEVEL = -1;
     public const SHORTCODE = 203;

diff --git a/src/Psalm/Issue/ImpurePropertyAssignment.php b/src/Psalm/Issue/ImpurePropertyAssignment.php
@@ -2,7 +2,7 @@
 
 namespace Psalm\Issue;
 
-class ImpurePropertyAssignment extends CodeIssue
+final class ImpurePropertyAssignment extends CodeIssue
 {
     public const ERROR_LEVEL = -1;
     public const SHORTCODE = 204;

diff --git a/src/Psalm/Issue/ImpurePropertyFetch.php b/src/Psalm/Issue/ImpurePropertyFetch.php
@@ -2,7 +2,7 @@
 
 namespace Psalm\Issue;
 
-class ImpurePropertyFetch extends CodeIssue
+final class ImpurePropertyFetch extends CodeIssue
 {
     public const ERROR_LEVEL = -1;
     public const SHORTCODE = 234;

diff --git a/src/Psalm/Issue/ImpureStaticProperty.php b/src/Psalm/Issue/ImpureStaticProperty.php
@@ -2,7 +2,7 @@
 
 namespace Psalm\Issue;
 
-class ImpureStaticProperty extends CodeIssue
+final class ImpureStaticProperty extends CodeIssue
 {
     public const ERROR_LEVEL = -1;
     public const SHORTCODE = 221;