Skip to content

Commit

Permalink
Apply suggestions from code review
Browse files Browse the repository at this point in the history
Co-authored-by: AndrolGenhald <AndrolGenhald@users.noreply.github.com>
  • Loading branch information
weirdan and AndrolGenhald committed Feb 5, 2022
1 parent e40bcc2 commit 8a41d61
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 4 deletions.
4 changes: 2 additions & 2 deletions docs/running_psalm/issues/PropertyNotSetInConstructor.md
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
# PropertyNotSetInConstructor

Unitialized properties are statically hard to analyze. To prevent mistakes, Psalm will enforce that all properties should be initialized.
Unitialized properties are hard to statically analyze. To prevent mistakes, Psalm will enforce that all properties should be initialized.

It does that through [MissingConstructor](issues/MissingConstructor.md) and this issue.

Expand All @@ -10,7 +10,7 @@ Doing that allows it to report missing initializations as well as [RedundantProp

This issue is emitted when a non-null property without a default value is declared but not set in the class’s constructor

If your project rely on having uninitialized properties, it is advised to suppress this issue, as well as [MissingConstructor](issues/MissingConstructor.md) and [RedundantPropertyInitializationCheck](issues/RedundantPropertyInitializationCheck.md).
If your project relies on having uninitialized properties, it is advised to suppress this issue, as well as [MissingConstructor](issues/MissingConstructor.md) and [RedundantPropertyInitializationCheck](issues/RedundantPropertyInitializationCheck.md).

```php
<?php
Expand Down
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
# RedundantPropertyInitializationCheck

Unitialized properties are statically hard to analyze. To prevent mistakes, Psalm will enforce that all properties should be initialized.
Unitialized properties are hard to statically analyze. To prevent mistakes, Psalm will enforce that all properties should be initialized.

It does that through [PropertyNotSetInConstructor](issues/PropertyNotSetInConstructor.md) and [MissingConstructor](issues/MissingConstructor.md).

Expand All @@ -10,7 +10,7 @@ Doing that allows it to report missing initializations as well as this issue.

This issue is emitted when checking `isset()` on a non-nullable property. Because every property is assumed to be initialized, this check is redundant

If your project rely on having uninitialized properties, it is advised to suppress this issue, as well as [PropertyNotSetInConstructor](issues/PropertyNotSetInConstructor.md) and [MissingConstructor](issues/MissingConstructor.md).
If your project relies on having uninitialized properties, it is advised to suppress this issue, as well as [PropertyNotSetInConstructor](issues/PropertyNotSetInConstructor.md) and [MissingConstructor](issues/MissingConstructor.md).

```php
<?php
Expand Down

0 comments on commit 8a41d61

Please sign in to comment.