Fix #7968 - combine and simplify types where necessary in ternary ana…

…lysis
vimeo · May 20, 2022 · 9908871 · 9908871
1 parent f960d71
commit 9908871
Show file tree

Hide file tree

Showing 2 changed files with 18 additions and 1 deletion.
diff --git a/src/Psalm/Internal/Analyzer/Statements/Expression/TernaryAnalyzer.php b/src/Psalm/Internal/Analyzer/Statements/Expression/TernaryAnalyzer.php
@@ -129,7 +129,12 @@ static function (Clause $c) use ($mixed_var_ids, $cond_object_id): Clause {
 
         $if_clauses = Algebra::simplifyCNF($if_clauses);
 
-        $ternary_context_clauses = array_merge($entry_clauses, $if_clauses);
+        $ternary_context_clauses = $entry_clauses
+            ? Algebra::simplifyCNF(array_merge(
+                $entry_clauses,
+                $if_clauses
+            ))
+            : $if_clauses;
 
         if ($if_context->reconciled_expression_clauses) {
             $reconciled_expression_clauses = $if_context->reconciled_expression_clauses;

diff --git a/tests/TypeReconciliation/TypeAlgebraTest.php b/tests/TypeReconciliation/TypeAlgebraTest.php
@@ -1202,6 +1202,18 @@ function baz(?int $foo): void {
                         if ($foo === null) {}
                     }'
             ],
+            'ternaryAssertionOnBool' => [
+                'code' => '<?php
+                    function test(string|object $s, bool $b) : string {
+                        if (!$b || is_string($s)) {
+                            return $b ? $s : "";
+                        }
+                        return "";
+                    }',
+                'assertions' => [],
+                'ignored_issues' => [],
+                'php_version' => '8.0',
+            ]
         ];
     }