Merge pull request #9009 from weirdan/allow-no-return-type-on-destruc…

…tors Fixes #9008
vimeo · Dec 26, 2022 · 9f5314b · 9f5314b
2 parents c1273a8 + 52da29e
commit 9f5314b
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 0 deletions.
diff --git a/src/Psalm/Internal/Analyzer/InterfaceAnalyzer.php b/src/Psalm/Internal/Analyzer/InterfaceAnalyzer.php
@@ -139,6 +139,7 @@ public function analyze(): void
                 $actual_method_id = $method_analyzer->getMethodId();
 
                 if ($stmt->name->name !== '__construct'
+                    && $stmt->name->name !== '__destruct'
                     && $config->reportIssueInFile('InvalidReturnType', $this->getFilePath())
                 ) {
                     ClassAnalyzer::analyzeClassMethodReturnType(

diff --git a/tests/MethodSignatureTest.php b/tests/MethodSignatureTest.php
@@ -916,6 +916,19 @@ final class B implements I
                         public function a(mixed $a): void {}
                     }',
             ],
+            'doesNotRequireInterfaceDestructorsToHaveReturnType' => [
+                'code' => '<?php
+                    interface I
+                    {
+                        public function __destruct();
+                    }
+
+                    class C implements I
+                    {
+                        public function __destruct() {}
+                    }
+                ',
+            ],
         ];
     }