Merge pull request #10104 from 6b7562617765726c6f73/fix_MethodCallAna…

…lyzer
vimeo · Aug 12, 2023 · a69eddd · a69eddd
2 parents 3098e51 + 35183b9
commit a69eddd
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 1 deletion.
diff --git a/src/Psalm/Internal/Analyzer/Statements/Expression/Call/MethodCallAnalyzer.php b/src/Psalm/Internal/Analyzer/Statements/Expression/Call/MethodCallAnalyzer.php
@@ -29,6 +29,7 @@
 use Psalm\IssueBuffer;
 use Psalm\Type;
 use Psalm\Type\Atomic\TNamedObject;
+use Psalm\Type\Atomic\TObject;
 use Psalm\Type\Atomic\TTemplateParam;
 use Psalm\Type\Union;
 
@@ -412,7 +413,7 @@ public static function analyze(
             $types = $class_type->getAtomicTypes();
 
             foreach ($types as $key => &$type) {
-                if (!$type instanceof TNamedObject) {
+                if (!$type instanceof TNamedObject && !$type instanceof TObject) {
                     unset($types[$key]);
                 } else {
                     $type = $type->setFromDocblock(false);

diff --git a/tests/MethodCallTest.php b/tests/MethodCallTest.php
@@ -1203,6 +1203,17 @@ public function method(mixed $value): mixed
                 'ignored_issues' => [],
                 'php_version' => '8.0',
             ],
+            'phpdocObjectTypeAndReferenceInParameter' => [
+                'code' => '<?php
+                    class Foo {
+                        /**
+                         * @param object $object
+                         */
+                        public function bar(&$object): void {}
+                    }
+                    $x = new Foo();
+                    $x->bar($x);',
+            ],
         ];
     }