Merge pull request #7844 from orklah/non-empty-string

fix refining lowercase string and non-empty-string together
vimeo · Apr 5, 2022 · d176361 · d176361
2 parents cab6f33 + b72f056
commit d176361
Show file tree

Hide file tree

Showing 2 changed files with 27 additions and 0 deletions.
diff --git a/src/Psalm/Internal/Type/AssertionReconciler.php b/src/Psalm/Internal/Type/AssertionReconciler.php
@@ -45,8 +45,11 @@
 use Psalm\Type\Atomic\TLiteralFloat;
 use Psalm\Type\Atomic\TLiteralInt;
 use Psalm\Type\Atomic\TLiteralString;
+use Psalm\Type\Atomic\TLowercaseString;
 use Psalm\Type\Atomic\TMixed;
 use Psalm\Type\Atomic\TNamedObject;
+use Psalm\Type\Atomic\TNonEmptyLowercaseString;
+use Psalm\Type\Atomic\TNonEmptyString;
 use Psalm\Type\Atomic\TNull;
 use Psalm\Type\Atomic\TNumeric;
 use Psalm\Type\Atomic\TObject;
@@ -793,6 +796,13 @@ private static function filterAtomicWithAnother(
             $matching_atomic_type = $new_range;
         }
 
+        // Lowercase-string and non-empty-string are compatible but none is contained into the other completely
+        if (($type_2_atomic instanceof TLowercaseString && $type_1_atomic instanceof TNonEmptyString) ||
+            ($type_2_atomic instanceof TNonEmptyString && $type_1_atomic instanceof TLowercaseString)
+        ) {
+            $matching_atomic_type = new TNonEmptyLowercaseString();
+        }
+
         if (!$atomic_comparison_results->type_coerced && $atomic_comparison_results->scalar_type_match_found) {
             $any_scalar_type_match_found = true;
         }

diff --git a/tests/AssertAnnotationTest.php b/tests/AssertAnnotationTest.php
@@ -2038,6 +2038,23 @@ public function assertSame($expected, $actual): void
                     }
                 ',
             ],
+            'assertNonEmptyStringWithLowercaseString' => [
+                'code' => '<?php
+
+                    /** @psalm-assert non-empty-string $input */
+                    function assertLowerCase(string $input): void { throw new \Exception($input . " irrelevant"); }
+
+                    /**
+                     * @param lowercase-string $input
+                     * @return non-empty-lowercase-string
+                     */
+                    function makeLowerNonEmpty(string $input): string
+                    {
+                        assertLowerCase($input);
+
+                        return $input;
+                    }',
+            ],
         ];
     }