Enable store_node_types for all test cases

vimeo · Feb 19, 2023 · d4a57c8 · d4a57c8
1 parent c8393bd
commit d4a57c8
Show file tree

Hide file tree

Showing 3 changed files with 2 additions and 31 deletions.
diff --git a/tests/ClosureTest.php b/tests/ClosureTest.php
@@ -2,7 +2,6 @@
 
 namespace Psalm\Tests;
 
-use Psalm\Context;
 use Psalm\Tests\Traits\InvalidCodeAnalysisTestTrait;
 use Psalm\Tests\Traits\ValidCodeAnalysisTestTrait;
 
@@ -13,36 +12,6 @@ class ClosureTest extends TestCase
     use InvalidCodeAnalysisTestTrait;
     use ValidCodeAnalysisTestTrait;
 
-    public function testLanguageServerFirstClassCallable(): void
-    {
-        $code = '<?php
-            function foo(): void {}
-
-            class A {
-                public static function publicStatic(): void {}
-
-                public function publicMethod(): void {}
-            }
-
-            foo(...);
-            A::publicStatic(...);
-            (new A())->publicMethod(...);
-        ';
-
-        $context = new Context();
-
-        $this->project_analyzer->setPhpVersion('8.1.0', 'tests');
-
-        $codebase = $this->project_analyzer->getCodebase();
-        $codebase->enterServerMode();
-        $codebase->config->visitPreloadedStubFiles($codebase);
-
-        $file_path = self::$src_dir_path . 'somefile.php';
-
-        $this->addFile($file_path, $code);
-        $this->analyzeFile($file_path, $context);
-    }
-
     public function providerValidCodeParse(): iterable
     {
         return [

diff --git a/tests/Traits/InvalidCodeAnalysisTestTrait.php b/tests/Traits/InvalidCodeAnalysisTestTrait.php
@@ -73,6 +73,7 @@ public function testInvalidCode(
         $this->expectExceptionMessageMatches('/\b' . preg_quote($error_message, '/') . '\b/');
 
         $codebase = $this->project_analyzer->getCodebase();
+        $codebase->enterServerMode();
         $codebase->config->visitPreloadedStubFiles($codebase);
 
         $this->addFile($file_path, $code);

diff --git a/tests/Traits/ValidCodeAnalysisTestTrait.php b/tests/Traits/ValidCodeAnalysisTestTrait.php
@@ -68,6 +68,7 @@ public function testValidCode(
         $this->project_analyzer->setPhpVersion($php_version, 'tests');
 
         $codebase = $this->project_analyzer->getCodebase();
+        $codebase->enterServerMode();
         $codebase->config->visitPreloadedStubFiles($codebase);
 
         $file_path = self::$src_dir_path . 'somefile.php';