Fixes

vimeo · Aug 30, 2022 · e5dce23 · e5dce23
1 parent be500e0
commit e5dce23
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 5 deletions.
diff --git a/src/Psalm/Internal/Analyzer/Statements/Expression/CallAnalyzer.php b/src/Psalm/Internal/Analyzer/Statements/Expression/CallAnalyzer.php
@@ -770,8 +770,7 @@ public static function applyAssertionsToContext(
                                     continue;
                                 }
 
-                                $assertion_rule = clone $assertion_rule;
-                                $assertion_rule->setAtomicType($atomic_type);
+                                $assertion_rule = $assertion_rule->setAtomicType($atomic_type);
                                 $orred_rules[] = $assertion_rule;
                             }
                         } elseif (isset($context->vars_in_scope[$assertion_var_id])) {

diff --git a/src/Psalm/Storage/Possibilities.php b/src/Psalm/Storage/Possibilities.php
@@ -52,8 +52,7 @@ public function getUntemplatedCopy(
                 );
 
                 foreach ($union->getAtomicTypes() as $atomic_type) {
-                    $assertion = clone $assertion;
-                    $assertion->setAtomicType($atomic_type);
+                    $assertion = $assertion->setAtomicType($atomic_type);
                     $assertion_rules[] = $assertion;
                 }
             } else {

diff --git a/tests/AlgebraTest.php b/tests/AlgebraTest.php
@@ -83,7 +83,7 @@ public function testNegateFormulaWithUnreconcilableTerm(): void
         $a1 = new IsType(new TInt());
         $formula = [
             new Clause(['$a' => [(string)$a1 => $a1]], 1, 1),
-            new Clause(['$b' => [(string)$a1 => clone $a1]], 1, 2, false, false),
+            new Clause(['$b' => [(string)$a1 => $a1]], 1, 2, false, false),
         ];
 
         $negated_formula = Algebra::negateFormula($formula);