Assertion dependent type not recognized in dev-master, but works in 4.x-dev.

[rzvc]

function test(mixed $mixed, bool $b) : void
{
	if ($b && !is_string($mixed))
		return;
    
	echo $b ? $mixed : '';
}

https://psalm.dev/r/8979ac9579

[psalm-github-bot]

I found these snippets:

https://psalm.dev/r/8979ac9579

<?php

function test(mixed $mixed, bool $b) : void
{
	if ($b && !is_string($mixed))
		return;
    
	echo $b ? $mixed : '';
}

Psalm output (using commit f960d71):

INFO: MixedArgument - 8:7 - Argument 1 of echo cannot be ''|mixed, expecting string

[orklah]

Possibly a regression of #7484

@muglug do you have an opinion on that?

[muglug]

This is a somewhat more simple reproducer: https://psalm.dev/r/3b5374dddc but removing the ternary fixes it: https://psalm.dev/r/7a167ba5cd

So it’s likely an issue with ternary analysis.

I’ll have a look at this tomorrow if you don’t get to it.

[psalm-github-bot]

I found these snippets:

https://psalm.dev/r/3b5374dddc

<?php

function test(string|object $s, bool $b) : string
{
	if (!$b || is_string($s)) {
		return $b ? $s : '';
    }
    return '';
}

Psalm output (using commit f960d71):

ERROR: InvalidReturnStatement - 6:10 - The inferred type 'object|string' does not match the declared return type 'string' for test

ERROR: InvalidReturnType - 3:44 - The declared return type 'string' for test is incorrect, got 'object|string'

https://psalm.dev/r/7a167ba5cd

<?php

function test(string|object $s, bool $b) : string
{
	if (!$b || is_string($s)) {
        if ($b) {
            return $s;
        } else {
		    return '';
        }
    }
    return '';
}

Psalm output (using commit f960d71):

No issues!

[muglug]

Fixed in latest by ensuring clause simplification in ternaries matches behaviour in if/else analysis