Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix crash on property access to undefined property on a class with a missing dependncy #10159

Merged
merged 1 commit into from
Aug 28, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 4 additions & 0 deletions src/Psalm/Storage/ClassLikeStorage.php
Original file line number Diff line number Diff line change
Expand Up @@ -501,6 +501,10 @@ public function hasAttributeIncludingParents(
}

foreach ($this->parent_classes as $parent_class) {
// skip missing dependencies
if (!$codebase->classlike_storage_provider->has($parent_class)) {
continue;
}
$parent_class_storage = $codebase->classlike_storage_provider->get($parent_class);
if ($parent_class_storage->hasAttribute($fq_class_name)) {
return true;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -5,11 +5,13 @@
namespace Psalm\Tests\Internal\Analyzer\Statements\Expression\Fetch;

use Psalm\Tests\TestCase;
use Psalm\Tests\Traits\InvalidCodeAnalysisTestTrait;
use Psalm\Tests\Traits\ValidCodeAnalysisTestTrait;

final class AtomicPropertyFetchAnalyzerTest extends TestCase
{
use ValidCodeAnalysisTestTrait;
use InvalidCodeAnalysisTestTrait;

public function providerValidCodeParse(): iterable
{
Expand Down Expand Up @@ -72,4 +74,21 @@ class C extends B {}
],
];
}

public function providerInvalidCodeParse(): iterable
{
return [
'undefinedPropertyAccessOnMissingDependency' => [
'code' => <<<'PHP'
<?php
class A extends Missing {}
function make(): A { return new A; }

make()->prop;
PHP,
'error_message' => 'UndefinedPropertyFetch',
'ignored_issues' => ['MissingDependency'],
],
];
}
}