Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce DuplicateProperty issue #10265

Merged
merged 3 commits into from
Oct 9, 2023

Conversation

tuqqu
Copy link
Contributor

@tuqqu tuqqu commented Oct 8, 2023

Emit a DuplicateProperty, whenever a class property (either instance or a static one) is defined twice.

@tuqqu
Copy link
Contributor Author

tuqqu commented Oct 8, 2023

@orklah do you know why Run Shepherd failed? Seems unrelated.

@orklah
Copy link
Collaborator

orklah commented Oct 8, 2023

Build is broken on master since last merge. There has been a discussion here: #10209 (comment) not sure what's going on

@robchett
Copy link
Contributor

robchett commented Oct 8, 2023

I've added a hotfix for the build errors #10268 and raised #10267 to track the source.

@tuqqu tuqqu force-pushed the introduce-duplicate-property-issue branch from 4ba1cc2 to 8edb886 Compare October 8, 2023 23:13
@tuqqu
Copy link
Contributor Author

tuqqu commented Oct 8, 2023

@robchett thanks, I've rebased the branch on the new master

@orklah orklah added the release:feature The PR will be included in 'Features' section of the release notes label Oct 9, 2023
@orklah
Copy link
Collaborator

orklah commented Oct 9, 2023

Thanks!

@orklah orklah merged commit 9b00ac0 into vimeo:master Oct 9, 2023
40 of 42 checks passed
@tuqqu tuqqu deleted the introduce-duplicate-property-issue branch October 9, 2023 19:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release:feature The PR will be included in 'Features' section of the release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants